Skip to content

device-raven, tools: haptics through feedbackd on the CS40L25A - #113

Merged
derekross merged 2 commits into
derekross:mainfrom
robotosaith:omamobile-raven-haptics-pr
Oct 29, 2026
Merged

derekross merged 2 commits into
derekross:mainfrom
robotosaith:omamobile-raven-haptics-pr

Conversation

@robotosaith

Copy link
Copy Markdown
Contributor

The rest of raven's haptics, with the driver in derekross/linux-omarchy-mobile#114: raven's kernel.config builds cs40l25-vibra, extract-vendor-firmware -d raven stages the CS40L25A's firmware from the owner's factory image, and a udev rule makes the motor a feedbackd vibra, as cheetah's.

The motor appears only once its firmware has loaded, about 5 s into the boot, and feedbackd looks for it only when it starts, so some boots had no haptics until feedbackd was restarted. The motor's arrival now restarts a running feedbackd. Tested on raven: key-press haptics on the keyboard, and the restart checked by replaying the motor's arrival. Version bump left to you.

🤖 Generated with Claude Code

@derekross

Copy link
Copy Markdown
Owner

Thanks. The udev rule follows cheetah's, and the rescan unit is a neat way around feedbackd looking for its devices only at start-up. It's good that you checked it by replaying the motor's arrival. The firmware mapping only touches raven's branch of extract-vendor-firmware and keeps the files out of the repository.

The red CI isn't yours: it's a flaky test in omamobile-audio that failed on several branches today (a fix is open in #107). device-raven's own tests pass in that run.

This merges after the driver (kernel #114), since CONFIG_INPUT_CS40L25_VIBRA only exists there. I'll set the version at merge and resolve the small test/all overlap with #112. A tools/phone-smoke report from your build would be welcome here as well.

@robotosaith

Copy link
Copy Markdown
Contributor Author

Smoke report from the build that runs this: derekross/linux-omarchy-mobile#112 (comment).

@derekross

Copy link
Copy Markdown
Owner

Thanks for the smoke report. It comes from a build with this PR's package changes in it (device-raven 0.1.23.5) and names the kernel, so that covers what I asked for here.

I checked the rest again against today's main and the driver's new head:

  • The udev rule matches the name the driver gives its input device (cs40l25_vibra). The firmware names extract-vendor-firmware stages (cs40l25a_clab.wmfw, cs40l20.bin) are the ones the driver requests, and CONFIG_INPUT_CS40L25_VIBRA is still the symbol's name after the rework.
  • The rescan unit only runs when the motor first appears. systemd acts on SYSTEMD_WANTS when a device first becomes active, not on later change events, so a routine udevadm trigger won't keep restarting feedbackd. A boot where feedbackd isn't running yet just runs pkill on nothing, and the - covers that.
  • Since device-raven: load the charger at boot, with its temperature guard #112 (the charger) merged, this conflicts with main in packages/omamobile-device-raven/test/all, in the list of staged files. The fix keeps both sides: the charger's two files, then your two. With that, device-raven's tests pass on the merge, and the policy check is clean. I'll resolve it at merge, so you don't need to push for it. The red CI run is the omamobile-audio flake I mentioned before. Its fix is on main now, so the next run should be green.

One small thing before merge, if you can: the plan's H5 result names two kernels from before the driver's rework (g97f09c8cfada, g3ba8c15c89b8). The driver has changed since then: the reset is now active-low, and the boost comes from the DT. On the kernel PR you booted the reworked driver as …-ge1e6adb69bbf and it probed with its firmware running. Could you add a line to H5 for that boot, and say whether key presses still tick on it? That ties "haptics work" to the driver that actually lands.

The order stays the same: the driver (kernel #114) first, once it's rebased with the one-line register-read fix, then this PR. I'll set the version at merge: 0.1.27, since #126 brings main's version file up to the 0.1.26 that #112 named.

The kernel side is derekross/linux-omarchy-mobile#114 (cs40l25-vibra, its
binding and raven's node). This is the rest:

- device/raven/kernel.config builds cs40l25-vibra as a module.
- extract-vendor-firmware -d raven stages the CS40L25A's files from the
  owner's factory image: the CLAB RAM firmware and the default wavetable,
  which the driver loads, and the CLAB configuration (braking), not
  loaded yet.
- device-raven's 72-omamobile-feedbackd.rules makes the motor a feedbackd
  vibra, as cheetah's CS40L26. The motor's input device appears only once
  its firmware has loaded, about 5 s into the boot, and feedbackd (D-Bus
  activated) only looks for it when it starts, so on a boot where
  something asked for feedback first there were no haptics until
  feedbackd was restarted. The motor's arrival now starts
  omamobile-feedbackd-rescan.service, which stops a running feedbackd;
  the next request starts it again with the motor.

HAPTICS-TORCH-PLAN records H5 and the boot race.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@robotosaith
robotosaith force-pushed the omamobile-raven-haptics-pr branch from e2793db to df34e24 Compare October 29, 2026 06:09
@robotosaith

Copy link
Copy Markdown
Contributor Author

Rebased onto main. The test/all conflict with #112 is resolved by keeping both sides (the charger's two files, then these two), so there's nothing left to fix at merge. H5 now has a line for the reworked driver's boot (ge1e6adb69bbf): it probes with firmware 0x1400cb running, and key presses on the on-screen keyboard still tick.

@derekross

Copy link
Copy Markdown
Owner

Thanks. The rebase keeps both sides of the test/all list as I described, and the H5 line ties "key presses still tick" to the reworked driver's boot. That's what I was after. device-raven's tests pass on this head, and the policy check is clean.

The one red job is the omamobile-audio c9 test flake again, not your change. Its fix is open in #150. I'll re-run CI once that's in, and merge when every check has finished.

I'll merge this right after the driver (derekross/linux-omarchy-mobile#114). At merge I'll set the version file to 0.1.27 and put it in the title, so they agree. Once both are in, I'll also update raven's Haptics cell in DEVICES.md to point at H5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derekross
derekross merged commit aafd1f4 into derekross:main Oct 29, 2026
2 checks passed
@robotosaith
robotosaith deleted the omamobile-raven-haptics-pr branch October 29, 2026 19:08
derekross added a commit that referenced this pull request Oct 30, 2026
The matrix and the Wanted list against what has merged since #140, with
each pull request's state checked on GitHub today:

- Pixel 7 (panther): the GPU and haptics nodes (kernel #129, #130) were
  closed because they landed unchanged through kernel #134, merged with
  the touchscreen node and s2idle by default; device-panther 0.1.1 (#145)
  carries the GPU's always-on rule, the feedbackd rule and the sleep.conf
  drop-in. GPU and Haptics stay "testing" and now cite #134, #145 and the
  2026-10-28 notes. Touch stays WIP: kernel #134's body records touches
  driving Hyprland and the PIN screen, but the driver fixes (kernel #133)
  and the kernel option with the touch notes (#149) are still in review.
  Suspend: "no" with the s2idle default named, since the notes say it
  hasn't run.
- Pixel 6 Pro (raven): Haptics "no" -> "works": HAPTICS-TORCH-PLAN H5
  passed (2026-10-28/29), cs40l25-vibra and the node merged as kernel
  #114, feedbackd's rule in device-raven 0.1.27 (#113). Display names
  its open kernel PR, #116.
- Pixel 7a (lynx): Bluetooth "no" -> WIP: the merged WIFI-PLAN (#133)
  records it scanning through its own UART; kernel #98 and #98 are in
  review. The Wanted line says so too.
- Pixel 7 Pro (cheetah) detail: Boot names the AVB footers a chained
  vbmeta_b needs (NOTES 2026-10-28 and 10-29, #104); Suspend describes
  the merged tier 1 auto-sleep (#64, off by default behind the
  omamobile-sleep toggle, P0-P5 on 2026-10-26) in place of the old
  "until S8" text. Nothing from the open #171, #172, #174-#176.
- Wanted: coral's #52 is merged, so its line no longer says "in review";
  flame gets a line for its native install in review (#55, #56, #58,
  #59, split out of #17); the OnePlus 13 (dodge) is listed with #111 and
  kernel #115, both open.

The Pixel 9a row and the Pixel 9 family line are left to #165. Every
status word still parses with the website's parseCell.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
…derekross#113)

* device-raven, tools: haptics through feedbackd on the CS40L25A

The kernel side is derekross/linux-omarchy-mobile#114 (cs40l25-vibra, its
binding and raven's node). This is the rest:

- device/raven/kernel.config builds cs40l25-vibra as a module.
- extract-vendor-firmware -d raven stages the CS40L25A's files from the
  owner's factory image: the CLAB RAM firmware and the default wavetable,
  which the driver loads, and the CLAB configuration (braking), not
  loaded yet.
- device-raven's 72-omamobile-feedbackd.rules makes the motor a feedbackd
  vibra, as cheetah's CS40L26. The motor's input device appears only once
  its firmware has loaded, about 5 s into the boot, and feedbackd (D-Bus
  activated) only looks for it when it starts, so on a boot where
  something asked for feedback first there were no haptics until
  feedbackd was restarted. The motor's arrival now starts
  omamobile-feedbackd-rescan.service, which stops a running feedbackd;
  the next request starts it again with the motor.

HAPTICS-TORCH-PLAN records H5 and the boot race.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* device-raven 0.1.27: the haptics version bump

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Derek Ross <derekross@gmail.com>
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
The matrix and the Wanted list against what has merged since derekross#140, with
each pull request's state checked on GitHub today:

- Pixel 7 (panther): the GPU and haptics nodes (kernel derekross#129, derekross#130) were
  closed because they landed unchanged through kernel derekross#134, merged with
  the touchscreen node and s2idle by default; device-panther 0.1.1 (derekross#145)
  carries the GPU's always-on rule, the feedbackd rule and the sleep.conf
  drop-in. GPU and Haptics stay "testing" and now cite derekross#134, derekross#145 and the
  2026-10-28 notes. Touch stays WIP: kernel derekross#134's body records touches
  driving Hyprland and the PIN screen, but the driver fixes (kernel derekross#133)
  and the kernel option with the touch notes (derekross#149) are still in review.
  Suspend: "no" with the s2idle default named, since the notes say it
  hasn't run.
- Pixel 6 Pro (raven): Haptics "no" -> "works": HAPTICS-TORCH-PLAN H5
  passed (2026-10-28/29), cs40l25-vibra and the node merged as kernel
  derekross#114, feedbackd's rule in device-raven 0.1.27 (derekross#113). Display names
  its open kernel PR, derekross#116.
- Pixel 7a (lynx): Bluetooth "no" -> WIP: the merged WIFI-PLAN (derekross#133)
  records it scanning through its own UART; kernel derekross#98 and derekross#98 are in
  review. The Wanted line says so too.
- Pixel 7 Pro (cheetah) detail: Boot names the AVB footers a chained
  vbmeta_b needs (NOTES 2026-10-28 and 10-29, derekross#104); Suspend describes
  the merged tier 1 auto-sleep (derekross#64, off by default behind the
  omamobile-sleep toggle, P0-P5 on 2026-10-26) in place of the old
  "until S8" text. Nothing from the open derekross#171, derekross#172, derekross#174-derekross#176.
- Wanted: coral's derekross#52 is merged, so its line no longer says "in review";
  flame gets a line for its native install in review (derekross#55, derekross#56, derekross#58,
  derekross#59, split out of derekross#17); the OnePlus 13 (dodge) is listed with derekross#111 and
  kernel derekross#115, both open.

The Pixel 9a row and the Pixel 9 family line are left to derekross#165. Every
status word still parses with the website's parseCell.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants