Skip to content

pinctrl: samsung: zumapro: accept wake requests on the wake-up EINTs - #67

Closed
W4HO-ham wants to merge 1 commit into
derekross:omamobilefrom
W4HO-ham:tegu-pinctrl-wake-v2
Closed

W4HO-ham wants to merge 1 commit into
derekross:omamobilefrom
W4HO-ham:tegu-pinctrl-wake-v2

Conversation

@W4HO-ham

Copy link
Copy Markdown
Contributor

This is #59 again. You merged it on 2026-10-26 at 23:23 UTC, but the omamobile branch on GitHub doesn't have it now: the merge commit isn't an ancestor of omamobile, and the file still has the old code. My guess is that the branch was republished after the merge from a tree without it.

Same commit, cherry-picked onto the current omamobile with no conflicts. checkpatch --strict is clean and the file builds with W=1. #61 and #59 were merged together and are both missing, so I'm resubmitting each.

The google,zumapro-wakeup-eint chip has no irq_set_wake, so a
wake-enabled consumer such as gpio-keys fails its suspend callback with
-ENXIO ("failed to configure IRQ 47 as wakeup source: -6" on the Pixel
9a) and the whole suspend aborts.

The wake-up EINTs are chained on GIC SPIs, which suspend_device_irqs()
leaves enabled, so for s2idle the pin only has to stay unmasked: reuse
gs101_wkup_irq_set_wake(), which records the request and writes no PMU
register. The G4 PMU system-wakeup masks remain unimplemented, and the
comment says so.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
@derekross

Copy link
Copy Markdown
Owner

Thanks for the resubmission, but this one is already in. #59 was rebase-merged as 3e2ebfddcd9a at 23:23 UTC yesterday, right after #53's 76ecd6ce28e0, and the branch has only moved forward since (29abc5e4dc70 for #61, then 33267e524f97 at 23:28 UTC, which is still the tip). drivers/pinctrl/samsung/pinctrl-exynos.c on omamobile has the .irq_set_wake = gs101_wkup_irq_set_wake line and your comment, and this PR's commit is byte-identical to 3e2ebfddcd9a: merging it onto the branch gives exactly the branch's tree, which is why the gate couldn't tell. The branch wasn't republished; your branch point is 9afbb1a87ffc, the tip from about 21:52 to 23:22 UTC, so I think your local omamobile was simply a couple of hours behind when you looked. A fresh git fetch should show both merges. #68 is the same for #61 (29abc5e4dc70).

Closing this one. Nothing else needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants