Skip to content

arm64: dts: qcom: sdm845: Add disabled Dipper FTS5 node - #249

Open
quatrixone wants to merge 1 commit into
derekross:omamobilefrom
quatrixone:dipper-fts5-disabled-node
Open

quatrixone wants to merge 1 commit into
derekross:omamobilefrom
quatrixone:dipper-fts5-disabled-node

Conversation

@quatrixone

@quatrixone quatrixone commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Add Dipper Mi 8 touchscreen GPIO/pinctrl definitions and an FTS5 node in the disabled state. The device repository can enable it with a small overlay after this DTS change merges.

Validation

  • RAM boots on 2026-11-12 used these node properties. The overlay boot captured touch contact, changing coordinates and release; the direct-DTS boot registered stmfts on event2.
  • The common dtsi blob e03a1e2c62cc5 is unchanged from those tested properties. This PR keeps the node disabled, so its default device tree does not probe touch.
  • git diff --check passed. CI runs W=1, dtbs_check, and sign-off checks on the current head.

The commit message records the stock/vendor source, tested reset and interrupt pin states, and the RAM boot results. This PR remains draft until owner review of that evidence.

@quatrixone
quatrixone force-pushed the dipper-fts5-disabled-node branch from 0d54884 to 16e9dad Compare November 16, 2026 23:17
@derekross

Copy link
Copy Markdown
Owner

Thanks for moving the touchscreen node into the board file with the overlay kept to a one-line enable; that is the split we want. The node is disabled, its pin states are in the base file, the binding and driver are already on the branch, CI's dtbs_check passes, and the values match what your device notes record from the phone.

Two things before it leaves draft, both in the commit message, since that is what lands here:

  1. Please say where the values come from and what ran. Your notes already have it: stock's fts@49 with fts,irq-gpio 31 and fts,reset-gpio 32, the vendor tree's ts_active group, the two supplies read in use, and the RAM boots of 2026-11-12 with these exact properties (the overlay boot with contact, coordinates and release, then the direct-DTS boot where stmfts registered). The dtsi blob is unchanged since the commit your notes pin (e03a1e2c62cc), so naming that blob ties the boots to this commit. The description says no image was built from this commit, which undersells it.
  2. The trailers: put Assisted-by: directly above Signed-off-by: with no blank line between them, and in the tree's form, Assisted-by: LLM Codex, as on your two merged dipper commits. As it is, git reads only the sign-off as a trailer.

Two questions rather than requests, because changing a tested node means another boot: the reset pin's default state has output-high, which releases reset before the driver runs its own sequence, and the vendor group pulls both pins up while here only the interrupt pin is. If that is what the working boot had, a line in the message is enough.

Small things: the subject would read better as arm64: dts: qcom: sdm845-xiaomi-dipper-common: …, since sdm845: looks like the SoC file, and it would be good to use the same author identity as your earlier dipper commits.

I didn't build this locally; CI's W=1 and device-tree checks passed on this head.

@quatrixone
quatrixone force-pushed the dipper-fts5-disabled-node branch 2 times, most recently from 32901e4 to 6dbbe41 Compare November 19, 2026 07:37
@quatrixone
quatrixone marked this pull request as ready for review November 19, 2026 08:11
Describe Dipper's ST FTS5 touchscreen while keeping board activation in a
separate overlay. Stock's fts@49 uses fts,irq-gpio 31 and
fts,reset-gpio 32. The vendor ts_active group uses GPIO31 and GPIO32
with 16 mA drive and pull-ups. The vddio and avdd supplies were read in
use on the phone and map to vreg_panel_vddio and vreg_l28a_3p3. The
tested node has an interrupt pull-up and output-high reset default,
which releases reset before the driver runs its own sequence.

RAM boots on 2026-11-12 exercised these properties: the overlay boot
reported touch contact, changing coordinates and release, and the direct
DTS boot registered stmfts on event2. The tested common dtsi content is
unchanged. Leave the node disabled until the separate board overlay is
selected.

Assisted-by: LLM Codex
Signed-off-by: Quatrix One <quatrix1@gmail.com>
Signed-off-by: Quatrix One <quatrixone@users.noreply.github.com>
@quatrixone
quatrixone force-pushed the dipper-fts5-disabled-node branch from 6dbbe41 to 0c4a7f7 Compare November 19, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants