Skip to content

Pixel 8a (akita): fix the storage guard comment - #214

Merged
derekross merged 1 commit into
derekross:omamobilefrom
aninmucek:omamobile-zuma-akita-guard-comment
Nov 8, 2026
Merged

derekross merged 1 commit into
derekross:omamobilefrom
aninmucek:omamobile-zuma-akita-guard-comment

Conversation

@aninmucek

Copy link
Copy Markdown
Contributor

A follow-up to #206, from its review. One comment-only commit, on today's omamobile:

  • arm64: dts: exynos: google: zuma-akita: Fix the storage guard comment. The comment above &ufs_0 said the init's storage guard runs before the disks appear. With UFS built in, it's the other way round: on a Pixel 8a the disks attach 0.26 s into boot, and /init starts at 0.28 s. What keeps them safe is that nothing mounts or writes them before the guard has set every partition except slot B's boot images and userdata read-only, which it had done by 0.61 s. The new wording is yours, from Pixel 8a (akita): enable UFS, as on the Pixel 8 Pro #206's review.

No change to the DTB: on today's omamobile, zuma-akita.dtb is byte-identical with and without this commit (sha256 1fc11092ab0fb98d…).

Checks: tools/kernel-pr-check --build OUT --merge origin/omamobile passes everything:

  • a clean merge onto 25368bf;
  • the sign-off: 1 commit, signed off by its author, none by an AI;
  • checkpatch --strict with no errors and no warnings;
  • the 10 Google device trees with W=1 and dtbs_check, with no new warnings.

🤖 Generated with Claude Code

The comment above the UFS host says the init's storage guard runs
before the disks appear. With UFS built in, it is the other way round:
on a Pixel 8a the disks attach 0.26 s into boot and /init starts at
0.28 s. What keeps them safe is that nothing mounts or writes them
before the guard has set every partition except slot B's boot images
and userdata read-only, which it had done by 0.61 s. Say that instead.

No change to the DTB.

Assisted-by: Claude Opus 5.5
Signed-off-by: DarekM <149845949+aninmucek@users.noreply.github.com>
@derekross

Copy link
Copy Markdown
Owner

Thank you, @aninmucek, for following up so quickly. The new comment matches your M2.3 timing and what the init does: it sets every partition except slot B's boot images and userdata read-only in its first pass, before anything mounts or writes them. I checked the claim that the DTB doesn't change: our gate's base and head builds of zuma-akita.dtb are both 1fc11092ab0fb98d…, the hash you gave. The gate passes on today's omamobile (clean merge, sign-off, checkpatch with no warnings, all ten Google device trees with no new warnings), and CI's dtbs_check is green.

I'll merge this as it is. The same sentence is in the Pixel 8 Pro's and the Pixel 9a's board files, and I'll fix both of those myself.

@derekross
derekross merged commit d349a61 into derekross:omamobile Nov 8, 2026
1 check passed
@aninmucek
aninmucek deleted the omamobile-zuma-akita-guard-comment branch November 8, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants