Repository navigation
Pixel 8a (akita): fix the storage guard comment - #214
Merged
derekross merged 1 commit intoNov 8, 2026
Merged
Conversation
The comment above the UFS host says the init's storage guard runs before the disks appear. With UFS built in, it is the other way round: on a Pixel 8a the disks attach 0.26 s into boot and /init starts at 0.28 s. What keeps them safe is that nothing mounts or writes them before the guard has set every partition except slot B's boot images and userdata read-only, which it had done by 0.61 s. Say that instead. No change to the DTB. Assisted-by: Claude Opus 5.5 Signed-off-by: DarekM <149845949+aninmucek@users.noreply.github.com>
Owner
|
Thank you, @aninmucek, for following up so quickly. The new comment matches your M2.3 timing and what the init does: it sets every partition except slot B's boot images and I'll merge this as it is. The same sentence is in the Pixel 8 Pro's and the Pixel 9a's board files, and I'll fix both of those myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #206, from its review. One comment-only commit, on today's
omamobile:&ufs_0said the init's storage guard runs before the disks appear. With UFS built in, it's the other way round: on a Pixel 8a the disks attach 0.26 s into boot, and/initstarts at 0.28 s. What keeps them safe is that nothing mounts or writes them before the guard has set every partition except slot B's boot images anduserdataread-only, which it had done by 0.61 s. The new wording is yours, from Pixel 8a (akita): enable UFS, as on the Pixel 8 Pro #206's review.No change to the DTB: on today's
omamobile,zuma-akita.dtbis byte-identical with and without this commit (sha2561fc11092ab0fb98d…).Checks:
tools/kernel-pr-check --build OUT --merge origin/omamobilepasses everything:checkpatch --strictwith no errors and no warnings;W=1anddtbs_check, with no new warnings.🤖 Generated with Claude Code