Skip to content

arm64: dts: exynos: google: zuma-husky: enable hsi2c_11, the MAX77759 bus - #205

Merged
derekross merged 1 commit into
derekross:omamobilefrom
Somnius:husky-hsi2c-11
Nov 7, 2026
Merged

derekross merged 1 commit into
derekross:omamobilefrom
Somnius:husky-hsi2c-11

Conversation

@Somnius

@Somnius Somnius commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

This is the hsi2c_11 change you wanted as its own PR: it turns on the bus, USI11, CMU_PERIC1 and its sysreg in zuma-husky.dts. Today a bring-up overlay does it on my phone.

Why: the USB replug rescue in the husky package needs the bus. The Type-C side opens its USB2 data switch on an unplug and with no Type-C driver nothing closes it, so the phone stays off the USB bus after a replug. With the bus there, the rescue brings the link back in about two seconds, I tested unplug and replug on the 8 Pro.

Binding the PMIC at 0x66 also creates the charger cell, so the charger driver programs limits from the battery node. omamobile-device-husky's omamobile-max77759.conf already blacklists max77759_charger, gpio_max77759, nvmem_max77759 and tcpci_maxim (a manual modprobe still works), so this DTB should go out with that package, I put that in the board file comment. The Type-C controller node stays disabled.

Tested: the same four nodes have been enabled by my overlay on the 8 Pro for days (gauge, PMIC, rescue work). This commit itself I only built, W=1, dt-validate shows only the two eusb2-phy messages that are there already. I haven't booted it as a board-file change.

#200 enables cmu_peric1 and sysreg_peric1 too (for haptics on USI0), so whichever of the two lands second can drop its copy of those two nodes.

… bus

The MAX77759 (PMIC, charger, fuel gauge, Type-C port controller) sits on
USI11 / hsi2c_11. The bus, USI11, CMU_PERIC1 and its SYSREG were left
disabled and a bring-up overlay switched them on. Move that into the
board file: the USB replug rescue in the husky device package needs the
bus, because the Type-C side opens its USB2 data switch on an unplug and,
with no Type-C driver, the phone stays off the USB bus after a replug
until something closes it again.

Binding the PMIC at 0x66 also creates its charger cell, and the charger
driver programs charge limits from the battery node. max77759_charger,
gpio_max77759, nvmem_max77759 and tcpci_maxim stay out of the way
through the husky device package's omamobile-max77759.conf (blacklist
only, a manual modprobe still works), so this DTB goes with that
package. The Type-C controller node stays disabled.

Update the comment that said the bus is enabled by an overlay and that
the package does not block the drivers yet.

Tested on a Pixel 8 Pro: the same four nodes were enabled by the
bring-up overlay for days; with them on, the fuel gauge, the PMIC and
the USB replug rescue work. This commit moves them into the board file
and was only built (W=1, dt-validate shows the two existing eusb2-phy
messages), not booted by itself.

Signed-off-by: Lef <me@lefteros.com>
@derekross

Copy link
Copy Markdown
Owner

Thank you, @Somnius, this is exactly the small PR I hoped for. To check it I applied your battery-i2c-test.dtso to today's husky DTB and compared the result with this PR's DTB: they're identical, so the days of boots with that overlay count as tests of this commit. The four cell drivers the comment mentions are blacklisted by omamobile-max77759.conf, which has been in the husky package since 0.1.4, so nothing new loads. Our gate and CI both pass.

I'll merge it. #200 also turns on cmu_peric1 and sysreg_peric1. That's harmless (dtc merges the two blocks), and whichever of the two goes in second can drop its copy. Once this is in, battery-i2c-test.dtso in omarchy-mobile has nothing left to do, so a small follow-up there can remove it.

@derekross
derekross merged commit c28645c into derekross:omamobile Nov 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants