Repository navigation
scsi: ufs: exynos: power the gs101 device down in system suspend too - #188
Conversation
gs101_ufs_suspend() asserts the device reset on gs101 as it does on gs201, which shares that function, but only gs201's init raised spm_lvl to 5. On a Pixel 6 Pro (gs101) at the core's default level 3 every s2idle resume failed its first Hibern8 exit and the error handler reset the host twice before the link came back (three Power-woken cycles on 2026-11-03: "ufshcd_uic_hibern8_exit: hibern8 exit failed. ret = 5", "host_reset: total cnt=2", then FAST series_B G4 L2 again, no I/O errors). At level 5 the same phone resumes through a full re-init with no error-handler pass. Set the level in gs101_ufs_drv_init(), which gs201's init only wrapped, and use it for gs201 directly: gs201 still gets level 5 from the same assignment, so the Pixel 7 Pro is unchanged. Assisted-by: Claude Opus 5.5 Signed-off-by: saiththerobo <the.tom.sharp@gmail.com>
|
Thank you, @robotosaith. This is a tidy fix, and the with/without table on raven is exactly the kind of evidence I checked the Pixel 7 Pro side. I built One small thing before I merge: could you add a Thanks also for tracing the UFS errors in #116's smoke report back to this. |
|
Thanks for comparing the object code on the 7 Pro. A boot of the tested tree today:
phone-smokephone-smoke: ravenKernel
Packages: hyprland 0.57.0-3.1, libcamera 0.7.2-4.22, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamessages 0.2.1-1, omamobile-apps 0.2.2-1, omamobile-audio 0.5.15-1, omamobile-device-raven 0.1.32-1, omamobile-firstboot 0.1.3-1, omamobile-gnss 0.2.7-1, omamobile-keyring 20261026-1, omamobile-mirror 0.1.1-1, omamobile-mmd 0.1.2-1, omamobile-modem 0.1.17-1, omamobile-modem-sit 0.3.30-1, omamobile-omarchy 0.1.31-1, omamobile-owl-widgets 0.1.2-1, omamobile-sensors 0.2.1-1, omamobile-shell 0.2.94-1, omamobile-voice 0.1.0-1, omaphone 0.2.2-1, omarchy 4.0.6-1, omatel-agent 0.2.4-2, quickshell 0.3.2.r7.g2b4501a-1 The three flags are this test kernel's, not the commit's: the published branch's reserved-memory overlap line, On oriole: it shares |
|
Thank you, @robotosaith. The smoke report, the release and the blob id are what I needed, and I confirmed the blob |
gs101_ufs_suspend()asserts the UFS device reset on gs101 exactly as on gs201 (gs201 shares it), but only gs201's init raisesspm_lvlto 5. On a Pixel 6 Pro at the core's default level 3, every s2idle resume fails its first Hibern8 exit and the error handler resets the host before the link comes back.The change: the
spm_lvl = UFS_PM_LVL_5assignment (and its comment) moves fromgs201_ufs_drv_init()intogs101_ufs_drv_init(), which gs201's init only wrapped, andgs201_ufs_drvs.drv_initpoints atgs101_ufs_drv_initdirectly. The Pixel 7 Pro still gets level 5 from the same assignment, in the same init, before the link comes up: nothing changes for gs201. zuma and zumapro are untouched.Tested on raven (Pixel 6 Pro), the same test kernel with and without this commit (
omamobile+ #116 + raven's NOT FOR MERGE USB override), threesystemctl suspendcycles each, woken by Power:gb0a658e17f21)g1094d975a193)spm_lvlat boothibern8 exit failed. ret = 5,host_reset: total cnt=2, register dumpsThe
dme-set: attr-id 0x4021 ... failed 0 retriesline after each resume is there in both and is already known totools/phone-smoke.Checks:
tools/kernel-pr-check --build --merge origin/omamobilein the project container: merges cleanly, checkpatch--strictclean, W=1 build ofufs-exynos.cclean, no device trees touched.Not tested: cheetah on this branch (the assignment it runs is the same one, now reached through
gs101_ufs_drv_init()).🤖 Generated with Claude Code