Skip to content

dt-bindings: soc: google: gs101-pmu: describe the CLKOUT pads - #183

Closed
derekross wants to merge 1 commit into
omamobilefrom
gs201-pmu-clkout-binding
Closed

derekross wants to merge 1 commit into
omamobilefrom
gs201-pmu-clkout-binding

Conversation

@derekross

Copy link
Copy Markdown
Owner

Fixes a dtbs_check warning my #104 landing introduced. The gs201 PMU node gained #clock-cells, clocks and clock-names in 8e84093 ("gs201: describe the PMU clock outputs"), but google,gs101-pmu.yaml has additionalProperties: false and didn't allow them, so gs201-cheetah and gs201-panther each gained one message:

system-controller@18060000 (google,gs201-pmu): '#clock-cells', 'clock-names', 'clocks' do not match any of the regexes

This allows #clock-cells (1), one input clock and its clkout0 name, as samsung,exynos-pmu.yaml does for the Exynos PMUs. With it, dt-validate on gs201-cheetah.dtb gives only the existing simplefb post-init-providers message. The binding's allOf: then is a dependency of else meta-schema note was already there before this change.

Needs Derek's sign-off. The commit has no Signed-off-by, because an AI may not add one, so the sign-off check fails as expected. To land it from the GitHub app, use Squash and merge and add your own Signed-off-by: Derek Ross <derekross@gmail.com> line in the commit message box.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d

The gs201 PMU node describes its CLKOUT pads as clock outputs
(#clock-cells, the TCXO as the CLKOUT mux's input 0), which the
exynos-clkout driver binds to provide the Pixel 7 Pro's NFC reference
clock. The binding didn't allow those properties, so dtbs_check flagged
the node on gs201-cheetah.

Allow #clock-cells, one input clock and its "clkout0" name, as
samsung,exynos-pmu.yaml does for the Exynos PMUs.

Assisted-by: LLM
@derekross

Copy link
Copy Markdown
Owner Author

Landed on omamobile as 3e58a14, the same change with Derek's sign-off, as a fast-forward. It clears the PMU #clock-cells/clocks/clock-names dtbs_check message on gs201-cheetah and gs201-panther.

@derekross derekross closed this Nov 1, 2026
@derekross
derekross deleted the gs201-pmu-clkout-binding branch November 1, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant