Repository navigation
Conversation
The gs201 PMU node describes its CLKOUT pads as clock outputs (#clock-cells, the TCXO as the CLKOUT mux's input 0), which the exynos-clkout driver binds to provide the Pixel 7 Pro's NFC reference clock. The binding didn't allow those properties, so dtbs_check flagged the node on gs201-cheetah. Allow #clock-cells, one input clock and its "clkout0" name, as samsung,exynos-pmu.yaml does for the Exynos PMUs. Assisted-by: LLM
Owner
Author
|
Landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a dtbs_check warning my #104 landing introduced. The gs201 PMU node gained
#clock-cells,clocksandclock-namesin 8e84093 ("gs201: describe the PMU clock outputs"), butgoogle,gs101-pmu.yamlhasadditionalProperties: falseand didn't allow them, so gs201-cheetah and gs201-panther each gained one message:This allows
#clock-cells(1), one input clock and itsclkout0name, assamsung,exynos-pmu.yamldoes for the Exynos PMUs. With it, dt-validate on gs201-cheetah.dtb gives only the existing simplefbpost-init-providersmessage. The binding'sallOf: then is a dependency of elsemeta-schema note was already there before this change.Needs Derek's sign-off. The commit has no Signed-off-by, because an AI may not add one, so the sign-off check fails as expected. To land it from the GitHub app, use Squash and merge and add your own
Signed-off-by: Derek Ross <derekross@gmail.com>line in the commit message box.🤖 Generated with Claude Code
https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d