Repository navigation
dt-bindings: arm: google: Document the soc_id property - #121
Merged
Merged
Conversation
The bootloaders of the gs101 and gs201 Pixels pick the base DTB by a
root soc_id property: they combine the SoC's product id register with
its major revision register and compare the result with the property's
first cell. Google's base device trees carry it as two cells, the
second zero, and so do the gs101 and gs201 boards here (oriole, raven,
cheetah, felix, panther); without it ABL rejects the DTB.
The schema didn't describe it, so dtbs_check couldn't decode it and
reported it on every one of those boards:
gs201-felix.dtb: / (google,gs201-felix): soc_id:
b'\t\x85P\x01\x00\x00\x00\x00' is not of type 'object', 'integer',
'array', 'boolean', 'null'
Describe it next to soc_compatible, which the zuma boards and the
Pixel 7a use instead.
Link: https://android.googlesource.com/kernel/devices/google/gs201/+/606d4345bc0dc66e3bc0a8deaa97cc288bbf53d1/dts/gs201-b0.dts
Link: https://android.googlesource.com/kernel/devices/google/gs101/+/51aa290c65e62f169eff2d12ebdd355354d7d966/dts/gs101-b0.dts
Assisted-by: Claude Opus 5.5
Signed-off-by: Derek Ross <derekross@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the root
soc_idproperty that Google's ABL matches the base DTB on (gs101 and gs201 boards: oriole, raven, cheetah, felix, lynx, panther; without it ABL rejects the DTB). Google's base device trees carry it as two cells (links in the commit).Every Google board in our tree has it, and
dtbs_checkcurrently reports it on each as an undocumented property ("soc_id: … is not of type 'object', 'integer', …"). That message made kernel #108's check fail as "new" for the Pixel 7, though its value is the Pixel 7 Pro's exactly. With this binding the message goes from five boards to none, and nothing else changes (validated by hand on every exynos/google board on the current tip; a bindings-only PR doesn't make the gate check boards).🤖 Generated with Claude Code