Repository navigation
Conversation
|
Thank you, @mrlund, and welcome. Getting the Adreno 830, IPA and WCN7860 running on a OnePlus 13 on top of our 7.3 base is a lot of work, and I appreciate how openly the description lists where each piece came from, including the commits whose original authors never signed off. I ran our kernel gate (
The bigger question is scope, and that part is mine to answer. This PR is 46 commits across about ten subsystems, 9,800 lines, mostly Qualcomm SoC enablement: the GPU catalog, gpucc, IPA, ath12k, MHI and PCIe. Upstream is moving fast on SM8750, and the Qualcomm phones we have so far keep their kernels in their own repositories. I want to decide whether linux-omarchy-mobile should carry this stack, or only the OnePlus 13 board on top of what's upstream, before either of us puts more time into this branch. I'll come back to you on that. In the meantime, the split you suggest ( One more thing for the record: the smoke tables come from a CI is waiting for my approval because this is your first PR. I'll approve it so you can see the same results. |
14599e9 to
8bce888
Compare
|
Thanks Derek — and thanks for running the gate and for approving CI on a first PR. Fixed the broken parts and pushed a rewritten CI on the old head was red for exactly those: missing author sign-offs, checkpatch on the gpu2 commit, the three W=1 warnings, and the DTS compatible/schema warnings. Done:
Sign-offs. Asking the authors now whether they'll sign off (hashes after the rewrite):
If they won't, those five stay out or get rewritten, per your call. Waiting on you for scope. Happy to split along the lines you liked ( |
|
Thank you, @mrlund, for the quick rework, and for holding off on the bigger changes until I've decided on scope. That saves us both time. I re-ran our gate (
Still open, so you have the full list when I come back on scope:
CI for this push is waiting for my approval again. I'll approve it so you see I'll come back to you on scope. Thanks for your patience with a series this size. |
8bce888 to
f5e354e
Compare
|
Thanks @derekross. Going through the still-open points. The branch is now at Up front: I edited index986’s commits that I carried — the board DTS cleanup, the memory node, and the touch prop rename in the Synaptics driver — and updated their
Short old to new for the pieces this round touched:
1. Sign-offs. Still the five above. Waiting on the authors. 2. Three compatibles. 3. Binding order. Board / panel / touch bindings now precede their first users. 4. CDSP / MPSS message. Now states that the board CDSP compatible falls back to 5. Scope-deferred. Shared-driver gates, the second Synaptics driver, moving SmokeA tip pack that left both
|
|
Thank you, @mrlund, for the clear old-to-new tables. They made this round quick to check. I went through the new head and ran our gate (
Still open:
For the record, I checked what this series changes for the Pixels: nothing. Every driver it touches is Qualcomm-only except CI for this push is waiting for my approval. I'll approve it so you can see I'll come back to you on scope. Thanks again for your patience with a series this size. |
f5e354e to
1dc357e
Compare
|
Thanks @derekross, and thanks for approving CI. The branch is now at 1. Sign-offs. Still the same five — I won't invent them. I've asked Teguh and index986. Current hashes:
Authorship and my 2. CDSP / MPSS. RAM-only boot of this tip with matching modules from a tmpfs overlay. Remoteprocs were NONE before the overlay. After the one-hand So in this tree only ADSP actually runs on its own. The commit message has that table (captured on 3. Board compatibles. Final 4. Sources. Board 5. Scope. Untouched, including the TBU address. Waiting on your call.
Device-side tip-image RAM boot of this kernel (UFS-off chain ~64 MiB, boot.img |
|
Thank you, @mrlund. The board commit now has the final WCN compatibles, the CDSP/MPSS message has the remote-processor table, and the Links point at commits. Our gate merges your head onto today's base, the touched C files build clean with W=1, and the 347 device trees show no new warnings. Two things remain apart from my scope decision:
On |
1dc357e to
4d42223
Compare
|
Thanks @derekross. 1. Trailer order. Fixed on the Adreno 830 GPU/GMU nodes commit: Teguh's Signed-off-by first, then my 2. hci_qca. His ROCKNIX patch ( 3. Sign-offs. Asked Teguh and index986 — no reply yet. Won't invent their Signed-off-by. If you're OK with a DCO 1.1 (b) fallback (I checked the published sources; licenses look fine for all five), I can re-sign the commits keeping their authorship, add my Signed-off-by under (b), and note that the original author didn't sign and where / under which license it was published. For the Synaptics driver, the copyright is Synaptics' (GPL-2.0); index986 only carried it, so (b) fits that one better than an index986 sign-off anyway. That would still leave their commits without an author Signed-off-by, so your gate would need to accept a (b) certification from me. Would you take that, or would you rather wait for them? 4. Scope. Still waiting on your call. |
|
Thank you, the trailers and the Co-developed-by look right now, and the tree hasn't changed, so the earlier builds hold. On the five sign-offs, let's give Teguh and index986 a few days. If they don't answer, I'd take the other route: you as the author of those commits, the original author named in the body with a link to the exact commit, and the original copyright kept in the files. Please also drop the duplicate Assisted-by lines (one per commit is enough). |
|
I've got a One Plus 13 and I'll try to help push this along with PRs of my own. In the meantime, send this review to your AI and tell it to verify the findings and make the change requests or push back with evidence: Review: OnePlus 13 (SM8750) bring-up |
qcom_pcie_config_sid_1_9_0() reads "iommu-map" as fixed 4-cell records
{bdf, phandle, sid, len}. SM8750 now uses #iommu-cells = <2> on
apps_smmu, so each record has 5 cells. The second record was read as
BDF 0x0001 with a garbage SID, BDF 0x0100 (the endpoint) got no
BDF_TO_SID entry, and its TLPs went out with the base SID 0x1400.
DMA still worked, because the root port and the endpoint share one
SMMU domain, but the ITS takes the DeviceID from that SID: endpoint
MSIs arrived as DeviceID 0x1400. The WCN7860 BHI interrupt (EventID 0)
landed on the root port's PME/AER vector and MHI timed out.
Read #iommu-cells from the IOMMU node and step through the records
with stride 3 + #iommu-cells.
Assisted-by: Grok Bot
Signed-off-by: Martin Lund <mrlund@hotmail.com>
… rejected ath12k_reg_chan_list_event() leaves pdev_idx at 255 on the ATH12K_REG_STATUS_DROP path (e.g. firmware rejects the requested country), so the 'out' label never finds an ar and never signals regd_update_completed. ath12k_regd_update() then waits for the full ATH12K_REG_UPDATE_TIMEOUT and logs 'Timeout while waiting for regulatory update'. Resolve the pdev from the event's phy_id on the DROP path when it is in range so the waiter is released. Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
The Adreno 830 GPU of SM8750 uses the chip-id compatible qcom,adreno-44050000. It already matches the generic chip-id pattern. Like the other A7xx/A8xx parts its clocks live in the GMU node, so add it to that list. It is not added to the two-region list: the SM8750 GPU node also describes the cx_dbgc region, which the generic three-entry reg-names list already allows. Assisted-by: Grok Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
The SM8750 GMU (qcom,adreno-gmu-830.1) has the same single register region and the same five clocks (ahb, gmu, cxo, memnoc, hub) as the Adreno 840 GMU, so share the 840.1 constraints. Assisted-by: Grok Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
Document the Awinic AW882308 (chip id 0x2308) smart amplifier used for the speakers and the earpiece of the OnePlus 13. It is controlled over I2C, takes I2S/TDM audio and has an optional reset line. Unlike the AW88395 family it needs no channel or firmware-name property, so it gets its own schema. Assisted-by: Grok Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
WCN7860 is the WCN7850 successor used with SM8750. Its Bluetooth part is powered from the same PMU outputs, so document it in the WCN7850 schema. Assisted-by: Grok Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
Add the SM8750 GPU clock controller, the GX clock controller and the Adreno SMMU. The Adreno 830 GPU and GMU nodes in the next commit need them. They come from ROCKNIX SM8750 patch 0033, which takes them from the upstream SM8750 gpucc DT series. Link: ROCKNIX/distribution@620baca [mrlund: backported ROCKNIX SM8750 patch 0033 (ROCKNIX, no original Signed-off-by) to 7.3-rc6] Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
Backport of ROCKNIX SM8750 patch 0038 (Teguh Sobirin), based on the upstream 'drm/msm: Support for Adreno 830 GPU' series. GPU disabled by default. The GPU register range covers the A830 RSCC at GPU base + 0x50000: a6xx_gmu_init() maps it there, and with only 0x40000 mapped the first runtime suspend faulted in a6xx_rpmh_stop(). Stock kgsl lists the RSCC at 0x3d50000 size 0x10000, so the range is 0x60000. Link: https://github.com/ROCKNIX/distribution/blob/620bacab32a18f4338e290c898d44c45f6db145a/projects/ROCKNIX/devices/SM8750/patches/linux/0038-arm64-dts-qcom-sm8750-add-GPU-nodes.patch Signed-off-by: Teguh Sobirin <teguh@sobir.in> [mrlund: backported to 7.3-rc6; squashed in the fix that grows the GPU register range to 0x60000 so it covers the A830 RSCC] Signed-off-by: Martin Lund <mrlund@hotmail.com> Assisted-by: Grok Bot
Backport of ROCKNIX SM8750 patch 0049 (Teguh Sobirin). chip id 0x44050000,
firmware gen80000_{sqe,gmu,aqe}. The GX GDSC and GXPD-vote fixes (ROCKNIX
0050/0051) are already in 7.3-rc6.
Link: ROCKNIX/distribution@620baca
[mrlund: backported ROCKNIX SM8750 patch 0049 to 7.3-rc6; the ROCKNIX
patch carries no Signed-off-by from the author]
Assisted-by: Grok Bot
Signed-off-by: Martin Lund <mrlund@hotmail.com>
Add oneplus,dodge to the SM8750 board compatible list. Signed-off-by: Martin Lund <mrlund@hotmail.com> Assisted-by: Grok Bot
Schema for the OnePlus 13 DSC panel driven by panel-aa569-p-3-a0019-dsc.c. Placed before the board DTS and the panel driver that use this compatible. Signed-off-by: Martin Lund <mrlund@hotmail.com> Assisted-by: Grok Bot
Schema for the Synaptics TouchComm SPI HBP controller used on the OnePlus 13 (S3910). Placed before the board DTS and the syna_tcm2_spi driver that use this compatible. Vendor properties (panel-coords, tx-rx-num, *-gpio) match what the carried Synaptics driver already reads; converting to standard touchscreen-* / reset-gpios would be a larger driver change. The oplus,dhall-ak09970 hall node has no driver in this tree and the oplus vendor prefix is not in vendor-prefixes.yaml; it is dropped in the board DTS rather than adding an unused binding. Signed-off-by: Martin Lund <mrlund@hotmail.com> Assisted-by: Grok Bot
Add a device tree for the OnePlus 13 (SM8750, codename dodge), carried over from the sm8750-mainline v6.16 tree: regulators, UFS, USB, the AA569 DSI panel, the Synaptics touchscreen, buttons, battery and charger, and the ADSP. The CDSP and modem are described but stay disabled. Later commits in this series enable Wi-Fi/Bluetooth, audio, rmtfs and the GPU on top of it. The memory map is left to sm8750.dtsi's memory@a0000000 (size 0); ABL fills it on a normal boot, and the dodge chainload stage2-dtb fills it from the phone's live FDT for kexec. A hardcoded memory@81960000 map from the v6.16 tree is dropped so it does not sit alongside that node. The WCN PMU and Bluetooth nodes use the final documented compatibles (qcom,wcn7850-pmu and qcom,wcn7860-bt) from the start; they stay disabled until later enable commits. The intermediate undocumented wcn7880-* names never appear. Link: sm8750-mainline/linux@0c17a4d644f0 [mrlund: Link is the sm8750-mainline commit that added sm8750-oneplus-dodge.dts (0c17a4d644f0). Taken from that tree's v6.16 tip commit 16cf517b2781 ("Very important fix") (index986, with contributions from others in that history; no Signed-off-by there) and ported to 7.3; CDSP and modem left disabled; DT cleanup for schema: dropped ddr_device_type, chip-name, panel_type, firmware_name, tp_ic_type, S3910_PANEL7 and TLMM input-enable on ts_int_active; renamed touchpanel,* to synaptics,panel-coords / synaptics,tx-rx-num; dropped oplus,dhall-ak09970 hall node and its pinctrl (no in-tree driver, oplus not in vendor-prefixes.yaml); left i2c_hub_9 empty; dropped the hardcoded memory@81960000 map so only sm8750.dtsi's memory@a0000000 remains for the bootloader / stage2-dtb to fill; folded final wcn7850-pmu / wcn7860-bt compatibles into this board commit so there is no later rename] Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
Config fragment used on top of the omamobile defconfig to build the OnePlus 13 (dodge) kernel: the SM8750 pinctrl, display, touch, audio and fuel-gauge options, plus early-boot builtins the qcom-abl chain needs (UFS host/PHY, USB gadget/configfs, Type-C, TCSRCC, simpledrm, and SM_GPUCC_8750 so Adreno SMMU/GPU clocks are present before the modules overlay). dodge's initramfs ships no modules, so those cannot stay =m. Link: sm8750-mainline/linux@ff68fefaca26 [mrlund: taken from the sm8750-mainline v6.16 tree (no Signed-off-by there) and adjusted for 7.3; early-boot =y for the abl chain] Signed-off-by: Martin Lund <mrlund@hotmail.com>
Add a driver for the AA569 (P_3_A0019) 1440x3168 DSC panel used on the OnePlus 13. The panel is driven in DSI command mode, as the stock bootloader and kernel do; video mode leaves it blank. The driver is carried over from the sm8750-mainline v6.16 tree and adjusted for 7.3, which no longer has dsc_slice_per_pkt. Link: sm8750-mainline/linux@23399a4ff9a1 [mrlund: taken from the sm8750-mainline v6.16 tree (index986, with fixes from AaronKel there; generated by linux-mdss-dsi-panel-driver-generator; no Signed-off-by there); switched to command mode, ported to 7.3, style fixes] Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
Two Awinic amplifiers (product id 0x2308) on hub I2C4 at 0x34 (left) and 0x35 (right), active-low resets on TLMM 2 and 164. The compatible is provisional until the part has a binding. Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
MI2S codecs such as speaker amplifiers are clock consumers; set the runtime format to I2S with the codec as consumer so the q6 I2S DAI drives BCLK and WS. Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
Secondary MI2S on q6apm to the two speaker amplifiers, with the i2s1 pins in their active state. Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
The OnePlus 13 has a WCD939x on the RX and TX SoundWire masters (reset on GPIO 101, supplies as on stock). Its built-in microphones are analog mics AMIC1 and AMIC5 on MIC BIAS1. Describe the codec and route its ADCs into TX codec DMA 3 so the card gets a capture PCM. Assisted-by: Grok Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
The OnePlus 13 has no 3.5 mm jack: analog headsets use USB-C audio accessory mode through the WCD939x USBSS switch at 0xe on QUP I2C3 (no reset line, as on stock). Link it into the pmic-glink connector's SBU port and the codec's headset port, and add the WCD playback link from RX codec DMA 0 to HPHL/HPHR. Assisted-by: Grok Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
The Bluetooth half of the WCN7860 sits on QUP UART14, as on stock (qcom,msm-geni-serial-hs at 0x898000 with the BT wake byte). Enable the qcom,wcn7860-bt node. Power comes from the PMU node's bluetooth target. Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
The panel's VCI supply (vreg_l13b_3p0) was constrained to 1.8 V. Stock asks for 3.0 V on that rail, and the SM8750 MTP and QRD boards set vreg_l13b_3p0 to 3.0 V. Use 3.0 V. Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
Stock allocates a 4 MiB rmtfs buffer (client-id 1) at boot. Mainline needs a fixed carve-out for rmtfs, so reserve one at the same place SM8650 uses, just below tz_merged. It is plain System RAM on stock. Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
dsi_get_cmd_fmt() returns CMD_DST_FORMAT_RGB101010 for RGB101010 panels. On the OnePlus 13 AA569 panel (DSC, widebus, SM8750) the first DCS command then times out. The panel works with RGB888, the format used before the RGB101010 case existed, so keep RGB888 when DSC is enabled. The AA569 panel needs this override together with widebus; gating the fallback to !widebus would break that panel. Other DSC+widebus boards that truly need RGB101010 can revisit this later. Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
Minimal I2C/regmap codec driver for the two Awinic smart amplifiers (product id 0x2308) on the OnePlus 13. Register tables come from firmware files generated from the phone's own ACF; volume is capped until speaker protection and calibration exist. The amplifier is unmuted from the DAI trigger, once BCLK is running, because it does not lock to a clock that starts after the unmute. Assisted-by: Grok Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
On the OnePlus 13 the top speaker doubles as the earpiece, using the stock Receiver tuning. Add an "Amp Profile" control (Speaker/Receiver) that loads aw882308-<addr>[-receiver].bin. The table is applied in hw_params while the amplifier is powered down and before the I2S setup, which it would otherwise overwrite; applying it at unmute left the PLL unlocked (SYSST 0x0011). The volume floor applies to both profiles. Assisted-by: Grok Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
On the OnePlus 13 (SM8750) a warm reboot often comes up with a black
panel. The panel driver's first DSI command-mode DMAs (memory fetches by
VBIF client xin7) complete twice and the third never does: "cmd dma tx
failed", "Failed to initialize panel: -110", DSI STATUS0 0x20003, lanes in
stop state, no DSI error and no SMMU fault, the iova still translates.
A DSI soft reset, a DSI link/PHY power cycle, a panel rail cycle, a VBIF
halt and the MDSS BCR do not clear it, and commands sent through the DSI
TPG FIFO (no memory fetch) still go through. It is never seen after a
true cold start.
The stale state survives the warm reset in the fetch path behind VBIF,
in the display QTB500 TBU of the apps SMMU (mdp_hf_qtb): a single CPU
read of its SWID_LOW register (offset 0; the downstream qtb500 driver
uses the same read as its write_sync) before the first fetch prevents
the third-fetch hang. Reading it after the hang does not recover it, so
the read has to come before the first fetch. The likely mechanism is
that a config-port access resynchronises the QTB clock/idle handshake
that the bootloader's warm reset left stuck; this is not confirmed by
documentation. Two controls at the same point do not help, which rules
out a plain bandwidth or MDSS-side wake:
- an extra mdp0-mem interconnect vote (400 MB/s avg, 1.6 GB/s peak),
- a read of the MDSS VBIF.
Results on warm boots where the bootloader splash autorefresh had
stalled at takeover (INTF1 line count 0xc60, the boots that fail),
2026-10-23:
arm stalled boots other boots
good/bad good/bad
QTB read (this patch) 8/0 11/0
no read (two controls) 2/2 15/0
extra mdp0-mem icc vote 0/1 6/0
VBIF read 0/1 1/0
Do the read in msm_mdss_enable(), after the MDSS clocks and interconnect
votes are up and before any display master fetches, so it also runs on
every runtime resume (screen wake).
The QTB is not a resource of the MDSS device and mainline DT has no node
for the SM8750 TBUs, so for now its physical address is per-SoC match
data (sm8750_data.hf_qtb_base; SM8750 gets its own msm_mdss_data for
it, since it shared data_57k) mapped with devm_ioremap(). Upstream, this
should become a DT phandle to a TBU node, or a sync hook in arm-smmu-qcom
(to be settled with the SMMU maintainers).
The same read covers the stall after an MDSS_GDSC collapse, so the GDSC
does not have to be kept on.
Assisted-by: Grok Bot
Signed-off-by: Martin Lund <mrlund@hotmail.com>
WCN7860 (PCI 17cb:110e) sets BHI_EXECENV to SBL, and later to AMSS, before the host has an event ring that could carry the EE event, so the event never arrives and the 90 s wait expires. Opt in with mhi_controller.ee_reg_continue (ath12k sets it for WCN7860 only). After the BHI load, continue from the register when it already shows SBL or AMSS/WFW and REG_ACCESS_VALID. After the AMSS download, poll BHI_EXECENV for up to 2 s and queue the mission-mode transition for AMSS/WFW only (not FP). Controllers that leave the flag clear are unchanged. Duplicate SBL / mission-mode transitions are still ignored when the event and the register path both fire. Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
WCN7860 (PCI 17cb:110e, "peach", the Wi-Fi/BT combo on SM8750 phones) reports SOC hw version 2 like WCN7850. Its UMAC register map, window register (0x3278), RX descriptor and 32-bit REO TLV rings are QCC2072's instead. Add ATH12K_HW_WCN7860_HW20 with the QCC2072 HAL map and hw_params based on QCC2072 (firmware in WCN7860/hw2.0), and claim the device in the wifi7 PCI driver. ATH12K_PCI_DEVICE_ID_WCN7860 goes in core.h, because QMI also needs it. Two differences from QCC2072: - The host feature list is PERST_NO_PULL | AUX_UC_SUPPORT (0x50), without QDSS_CFG_MISS. With that bit set, the firmware starts initializing before the host has sent the aux ucode and QDSS config, refuses both with QMI error 90 and asserts in the aux MAC wakeup. The vendor driver sets the bit only when the QDSS file is missing. - The DMA masks are limited to 28 bits. Without that, coherent allocations for this chip land at the top of the 32-bit space, while the vendor driver's DMA window for it is the low 384 MiB. The 28-bit mask keeps the firmware segments inside that window. Assisted-by: Grok Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
WCN7860 needs more from the host before it reaches mission mode than the other chips: - TME-Lite: the vendor driver hands tmel_peach_20.elf to the firmware, by DMA address over QMI (WLFW_TME_LITE_INFO, 0x5B), after target capabilities and before board data. A failure is logged and the sequence continues, as the vendor driver does. - M3: the M3 image is phy_ucode20.elf, loaded into DMA memory and announced with the usual M3 info request. - QDSS trace config: qdss_trace_config_v2.cfg is sent after the aux ucode (WLFW_QDSS_TRACE_CONFIG_DOWNLOAD, 0x44). A missing file is not fatal. - Regdb: board-2.bin has no regdb for this chip, so a failed regdb load does not stop the board data download. - The cold-boot calibration done indication (0x3E) is handled, so a later host capability message reports cal_done. All of it is keyed on the WCN7860 device id. Other chips take the existing paths. The aux ucode is loaded by the existing QCC2072 code, from WCN7860/hw2.0/aux_ucode.bin (the vendor aux_ucode20.elf). Assisted-by: Grok Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
…READY If the firmware crashes before QMI FW_READY, ath12k_core_reset() only warns and returns, and the RDDM dump that the MHI layer captured is lost. Collect it before returning, so early firmware crashes, like those seen while bringing up WCN7860, can be analysed. Also log RDDM entry at debug level. Assisted-by: Grok Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
WCN7860 (peach, the Wi-Fi/BT combo on SM8750 phones) is a WCN7850 derivative on UART. Its rampatch is an ELF image (gngbtfwXX.mbn) and its NVM is gngbtnvXX.*, and the peripheral (UWB) core sharing the UART needs its own baud rate packet before the speed change. Add QCA_WCN7860 with the WCN7850 handling plus those differences and the qcom,wcn7860-bt compatible. Power still goes through the WCN7850 power sequencer. Based on the ROCKNIX SM8750 patch by Teguh Sobirin (From: Teguh Sobirin <teguh@sobir.in>), which carries his Signed-off-by there. WCN7860 is added next to WCN7850 in the regulator/power, enable-gpios and power-off switches. Its soc data does not set QCA_CAP_HFP_HW_OFFLOAD, which WCN7850 has; that stays off until it is tested on WCN7860. Link: ROCKNIX/distribution@686ac3c995c8 Co-developed-by: Teguh Sobirin <teguh@sobir.in> Signed-off-by: Teguh Sobirin <teguh@sobir.in> Signed-off-by: Martin Lund <mrlund@hotmail.com> Assisted-by: Grok Bot
Zap shader from the stock (OEM-signed) firmware, installed on the phone as qcom/sm8750/OnePlus/gen80000_zap.mbn. Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
Document qcom,eliza-ipa for the Eliza platform, which uses IPA version 5.5.1 (a minor revision of v5.5). Signed-off-by: Alexander Koskovich <akoskovich@pm.me> Link: https://lore.kernel.org/linux-arm-msm/20260416-eliza-ipa-v1-1-f4109a8e43c4@pm.me/ [mrlund: drop the permanent SM8550-fallback claim; Eliza is made standalone together with SM8750 in a later commit] Signed-off-by: Martin Lund <mrlund@hotmail.com> Assisted-by: Grok Bot
Some IPA firmware versions on IPA 5.5 require ipa_filter_stats_info in the init_modem_driver QMI request. For example on Eliza, if this is not passed then shortly after IPA init the system will halt and reboot shortly after. Downstream this is marked as optional but does not seem to be the case on newer IPA firmware versions. Signed-off-by: Alexander Koskovich <akoskovich@pm.me> Link: https://lore.kernel.org/linux-arm-msm/20260416-eliza-ipa-v1-3-f4109a8e43c4@pm.me/ [mrlund: keep shared v4.5–v5.5 fnr_idx_cnt at 0 so older platforms keep the previous QMI layout; Eliza's non-zero count is in its private data] Signed-off-by: Martin Lund <mrlund@hotmail.com> Assisted-by: Grok Bot
Add the configuration data required for Eliza, which uses IPA v5.5. Eliza differs from the shared v5.5 tables in three ways: a larger Q6 FnR counter count (and the memory layout that follows), and private QSB and GSI endpoint tables. Signed-off-by: Alexander Koskovich <akoskovich@pm.me> Link: https://lore.kernel.org/linux-arm-msm/20260416-eliza-ipa-v1-4-f4109a8e43c4@pm.me/ [mrlund: keep private QSB and endpoint tables here instead of rewriting the shared v5.5 tables; set fnr_idx_cnt to 68 for Eliza] Signed-off-by: Martin Lund <mrlund@hotmail.com> Assisted-by: Grok Bot
SM8750 has IPA v5.5.2, like Eliza. The OnePlus SM8750 downstream driver uses the same 68-counter Q6 FnR memory layout and the same endpoint map as the Eliza data, so reuse ipa_data_v5_5_eliza. List both qcom,sm8750-ipa and qcom,eliza-ipa as standalone compatibles with no qcom,sm8550-ipa fallback. Move Eliza out of the SM8550 fallback list while adding SM8750. Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
Add the IPA v5.5 node, based on SM8650. The values come from the stock SM8750 device tree and the downstream sun-ipa.dtsi: - IPA interrupt is SPI 655 (SM8650: 654) - the config path ends at SLAVE_IPA_CFG on cnoc_main - the modem tables live at IMEM 0x14683000, size 0x2000 Add the IMEM node that holds the modem tables. Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
The GSI firmware comes from the modem partition (ipa_fws, PAS id 15). Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
Turn on the CDSP and modem remoteprocs now that firmware names and carve-outs are wired. Keep the risk comment: probing the modem hands its memory to the modem VM. What the driver does for these board compatibles (see drivers/remoteproc/qcom_q6v5_pas.c): - CDSP falls back to sm8650_cdsp_resource (qcom,sm8650-cdsp-pas in the board fallback list). That desc has auto_boot = true, so the CDSP firmware is expected to start at each boot without userspace. - MPSS uses sm8750_mpss_resource: auto_boot = false, but region_assign_idx/count/vmid hand the carve-out to the modem VM (QCOM_SCM_VMID_MSS_MSA) at probe. That assign happens whether or not the owner has enabled the modem in userspace. On a RAM-only boot of this series (7.3.0-rc6-g9957f46a70c4, 2026-10-30), after loading this kernel's qcom_q6v5_pas from a tmpfs modules overlay (remoteprocs were NONE before that modprobe): /sys/class/remoteproc/remoteproc0 name=modem state=offline /sys/class/remoteproc/remoteproc1 name=adsp state=running /sys/class/remoteproc/remoteproc2 name=cdsp state=offline CDSP auto-boot ran and failed with -2 (qcom/sm8750/OnePlus/cdsp.mbn not installed). MPSS stayed offline; the carve-out assign at probe is from the driver, not observed. So in this tree only ADSP actually runs. Assisted-by: Grok Bot Signed-off-by: Martin Lund <mrlund@hotmail.com>
4d42223 to
6cc4b65
Compare
|
Thanks a lot for this, and great to hear you've got a 13 too. I went through every item, and most of it holds up. Fixed in this revision:
Pushing back or leaving for now:
I RAM-booted this tip on the 13 against Derek's latest main with the lean config. Display, GPU, touch, Wi-Fi, BT, audio (speaker) and battery all work. SEA stays at 0, and the only WARNs are four clk ones. Looking forward to your PRs. |
|
Thank you, @mrlund, for working through @HundredBillion's review so quickly, and thank you, @HundredBillion, for such a thorough read. The rework fixes real bugs: the touch parser's unchecked indices and the lock it left held, the panel's missing supplies, the shared IPA v5.5 tables, the ungated MHI poll, and the config fragment that turned the GPU clocks off. I promised you a decision on scope, and here it is. What linux-omarchy-mobile carries. Its So I'd like to handle the OnePlus 13 the way the Pixel 4 XL is handled: the SoC stack stays in your fork ( That means I'll close this PR rather than merge it. Nothing here is wasted: the fork keeps all of it, and the review history stays linked from the device notes. For the record, here's where this head stands, so the fork starts from an accurate list:
Our policy gate on this head agrees: subjects and the identifier checks pass, checkpatch reports no errors, and only the five sign-offs fail. I didn't rebuild the series this time; CI for this push is waiting for my approval, and I'll approve it so you have the build and Thank you for your patience while I made up my mind, and for how openly you've documented every source. I'm glad the OnePlus 13 is part of the project, and I'm looking forward to the board PR. |
|
Thanks Derek. The fork model makes sense, and I'll keep the SoC stack on mrlund/linux-omarchy-mobile the way coral does. I've tagged the #115 tip as Separately, Looking forward to board pieces landing as their SoC deps reach upstream. |
arm64: qcom: OnePlus 13 (dodge) bring-up (gpu2 + IPA)
Base:
omamobileBranch:
dodge/pr-kernel-v1on https://github.com/mrlund/linux-omarchy-mobileConfig profile verified: gpu2 (
CONFIG_QCOM_IPA=m, MSM DRM)Companion device PR: derekross/omarchy-mobile#111
Summary
Subsystem-split series for the OnePlus 13 (SM8750 / Snapdragon 8 Elite):
board DT, display/panel, Adreno GPU (incl. A830 catalog + RSCC), IPA for
modem data, audio, Wi-Fi/BT, sensors/touch, and related bindings. Curated
from the private gpu2 tree; DIAG / trial / splash / fastrpc / only_adsp
experiments dropped. Modem (MPSS) and CDSP remoteproc nodes are enabled
to match the gpu2 runtime Martin runs today (IPA included); only the
skip_tmeath12k trial knob is dropped from source.Suggested follow-up split for review (same commits, tip refs on the fork):
dodge/pr-k-shareddodge/pr-k-gpu-socdodge/pr-k-pre-ipadodge/pr-k-ipaFeature matrix (kernel side)
sm8750-oneplus-dodge.dtsPhone-smoke evidence
Non-persistent
fastboot bootof the curated chain (LOCALVERSION-dodge-gpu2, vermagic match to modules already on the phone). Slot Bleft on the prior gpu2 flash image (nothing written to boot partitions).
Never
set_active a.Diff-equivalence vs private gpu2 (curated-touched paths)
same=48diff=4only_curated=1only_gpu2=0Documentation/devicetree/bindings/display/msm/gmu.yamlqcom,adreno-gmu-830.1(DTS uses it)Documentation/devicetree/bindings/display/msm/gpu.yamlDocumentation/devicetree/bindings/net/bluetooth/qcom,wcn7850-bt.yamlDocumentation/devicetree/bindings/sound/awinic,aw882308.yamldrivers/net/wireless/ath/ath12k/qmi.cskip_tmemodule_param (trial); TME path default retainedAll other curated-touched paths byte-identical to gpu2. Intended DIAG/trial
drops listed in
pr-work/intended-drops.txt(PCI iATU dumps, Gen2/1-lanetrials, splash identity-map, DSI/DPU DIAG, only_adsp, etc.).
Provenance / missing author SoBs
All commits carry my
Signed-off-by. Original authorship is kept. Wherethe upstream/source history had no author Signed-off-by, that is
disclosed here for Derek to decide (carry / rewrite / drop) — I am not
inventing SoB lines:
index986): taken fromsm8750-mainline/linux v6.16 (
Link:in each commit) and ported to 7.3.The originals have no Signed-off-by from index986 (handle only).
author and no Signed-off-by. Backported with
Link:+[mrlund: …].Signed-off-by from that patch is kept.
Signed-off-by from him in that patch.
with his SoB).
Assisted-by: Grok Botis on the commits an AI assistant helped with; Ireviewed and tested all of it. (Panel driver still carries generator/
source-tree comment markers — not open work.)
Phone smoke (boot_b, curated tip vs gpu2 baseline)
Trial via
fastboot boot(non-persistent) then restore; LEFT_ON = boot_b gpu2 (7.3.0-rc6-dodge-gpu2).Diff-equivalence vs gpu2: same=48, CONTENT_DIFF=4, ONLY_CURATED=1 (bindings + skip_tme drop + aw882308.yaml); drops justified. See
pr-work/diff-equiv-final-table.md.