Repository navigation
Input: add FocalTech FT3658 SPI touchscreen driver (Pixel 7) - #109
Conversation
The FT3658 is the touch controller of the Google Pixel 7, on SPI. It runs its own firmware from flash and needs a digital and an analog supply, an active-low reset and an interrupt line. The FocalTech parts in edt-ft5x06.yaml are I2C controllers and are not compatible. Assisted-by: Claude Opus 5.5 Signed-off-by: Alejandro Garcia <skipper.pelygro@gmail.com>
The Google Pixel 7 (panther) uses a FocalTech FT3658 touch controller on SPI. Mainline has no driver for it: edt-ft5x06 covers FocalTech's I2C family only. The controller runs its own firmware from flash. This driver powers it up, waits for its chip ID (0x56) and reports up to ten touches with the MT slot protocol; it never writes a register or the firmware. The SPI framing (a read command with a 16-bit length, three dummy bytes, a status byte and a CRC-16/CCITT over the data), the report layout and the power sequence follow Google's GPL FocalTech driver for Pixel devices: AVDD on, VDD on, 1 ms, reset released, then 200 ms for the firmware to boot; on removal reset is asserted before both supplies go off, so the supplies never drop under a running controller. Suspend, firmware update, gestures and the heatmap are not supported. Tested on a Pixel 7 from slot B, with the panther board file and its touch node: the controller answers with chip ID 0x56 and firmware version 0x16; touches at the four corners report (44, 19), (1071, 45), (34, 2389) and (1033, 2333) on the 1080x2400 panel, with no CRC or status error in 1632 reports; the lock screen takes a PIN by touch. Unbinding asserts reset and switches both rails off. Built as a module, it loads from its OF alias at boot. Assisted-by: Claude Opus 5.5 Signed-off-by: Alejandro Garcia <skipper.pelygro@gmail.com>
|
Thank you, @nesmeck. A small, read-only driver with a clear power sequence is exactly what a first touch driver should be. I checked it against Google's driver (
The driver never writes the controller's flash. That matters because Google's driver updates the firmware at probe, and this one skips that. The W=1 build is clean. It merges cleanly with #108. Nothing here blocks. A few suggestions for the upstream version, in any order:
On your two questions: for this tree, no MAINTAINERS entry is needed, as for the other touch drivers. I'll come back to you on the binding's When the touch node lands, the omarchy-mobile side will also need |
The matrix after the merges since #118, with each cell going by the merged notes: - Pixel 7 (panther): the board file (derekross/linux-omarchy-mobile#108) and the FT3658 touch driver (derekross/linux-omarchy-mobile#109) have merged into the published kernel, so Boot, Storage, Buttons and USB net say "in the published kernel" instead of "in review". Touch stays "no": the driver and the touch rails are published, but the board file has no touch node, and panther's notes end at boot 8 with the controller not answering. BRINGUP-M1's status and NOTES' header say the same. - Pixel 6 Pro (raven), Charging: no -> works. device-raven 0.1.26 (#112, #126) loads the MAX77759 charger at boot with its temperature guard; USB-PLAN section 4 records C0-C5 passed on 2026-10-28, a full charge to 100 % included. The battery node is derekross/linux-omarchy-mobile#112; the runs were on an unpublished integration kernel, and the cell says so. - raven, Torch: still works; the LED's node is now in the published kernel (derekross/linux-omarchy-mobile#113), tested on omamobile-gs101-torch and not yet run from the published kernel. - Pixel 9a (tegu), Fingerprint: no -> WIP. FINGERPRINT-PLAN records F0 and F2-F6b passed on an unpublished kernel: Trusty's TA runs and the HAL sees the sensor; enrollment waits for the factory calibration (F6c). omamobile-fingerprint 0.1.10 (#101) maps Trusty's stores for it. Left as they were: tegu's Charging (the MAX77779 charger driver, derekross/linux-omarchy-mobile#92, is published, but tegu's notes record no run of it), the gs201 HSI2 pin controller (derekross/linux-omarchy-mobile#123, no cell), felix (#35 is a plan) and cheetah (nothing merged for it). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A driver for the FocalTech FT3658, the Pixel 7's touch controller, on SPI. Mainline has none: edt-ft5x06 covers FocalTech's I2C parts only.
Two commits:
dt-bindings: input: touchscreen: add FocalTech FT3658: SPI, vdd and avdd supplies, active-low reset, an interrupt, the touchscreen size required;Input: add FocalTech FT3658 SPI touchscreen driver: powers the controller up in the order Google's GPL FocalTech driver uses (AVDD, VDD, 1 ms, reset released, 200 ms for the firmware), waits for chip ID 0x56, and reports up to ten touches with the MT slot protocol. It reads only: no register or firmware writes. The SPI framing (read command, 16-bit length, three dummy bytes, status byte, CRC-16/CCITT over the data), the report layout and the power-off order (reset first, then both supplies) follow Google's driver.Not supported yet: suspend, firmware update, gestures and the heatmap.
Tested on a Pixel 7 (slot B), kernel
7.3.0-rc6-omamobile-push1-g08996b25d807:omamobileat 6beaf6d plus this series, the panther board series (#108) and its touch node (touchscreen@0on USI0 SPI, reset gpp23-2, interrupt gpa7-0 falling edge, LDO25M/LDO26M):FT3658, chip id 0x56, firmware 0x16, 3.7 s into the boot;Checks:
tools/kernel-pr-check --build OUT --merge origin/omamobilepasses (W=1 build, dt_binding_check, checkpatch --strict with only the new-file MAINTAINERS note).Two questions:
maintainers:entry. I put myself there for now, but I can't take on maintaining it upstream; would you rather be listed?🤖 Generated with Claude Code