feat: enable search on batches#827
Merged
Kevin Loftus (kevin-loftus-dept) merged 1 commit intoJul 6, 2026
Merged
Conversation
2bf96e6 to
f4d0daf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title*
Enable batch name search on Data Collections Samples tab
Type of Change*
Description
The Samples tab search on the Data Collections page previously filtered only on sample
Name. Users could not find samples by batch, even though samples are grouped visually by batch in the UI.This change extends search to also match batch tag names (
Kind === 'batch'). When a query matches a batch name, all samples in that batch are shown. When it matches a sample name, only that sample is shown (existing behavior). Search remains case-insensitive and uses substring matching.Implementation details:
filterSamplesBySearch()topackages/front-end/src/app/utils/data-collections-filters.tsas a pure, unit-testable helper (same pattern as existing filters in that file).EGSamplesTab.vueandEGSampleTagSidebar.vueso the main sample list and left-rail tag chip counts stay in sync.No backend or API changes — samples and tags are already loaded client-side on the page.
Testing*
filterSamplesBySearchinpackages/front-end/test/app/utils/data-collections-filters.test.ts, covering:pnpm exec jest test/app/utils/data-collections-filters.test.ts— all 19 tests pass.Manual verification recommended:
Impact
Additional Information
The previous placeholder said "Search by sample ID or tag…" but standard tag name search was never implemented. This PR updates the placeholder to reflect what is actually searchable (sample ID and batch).
Checklist*