Move imports from deno.json to package.json - #3
Open
niLPotential wants to merge 3 commits into
Open
Conversation
|
This solved the npm TS2307 errors for me. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the template is as of now, when I typecheck with
deno check .the following error shows.These errors imply that deno fails to locate the libraries, despite them being installed.
The same errors appear when setting
nodeModulesDirtoautoindeno.json.But the error changes to the following when setting
nodeModulesDirtomanual.Finally, only when the imports are moved to a seperate
package.json, the typecheck passes.This probably is a node compatibility issue, which I hope will be addressed soon.
In the mean time, I propose to add this band-aid
package.jsonto avoid confusion.Also,
@types/react-domis added as dep anddeno.lockis updated.