fix(fragment): handle manual masks in collector#139
Closed
divybot wants to merge 1 commit into
Closed
Conversation
littledivy
reviewed
Jun 7, 2026
Co-Authored-By: Divy Srivastava <me@littledivy.com>
littledivy
force-pushed
the
orch/divybot-513
branch
from
4e115f4 to
4491058
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle manual masking with FragmentCollector when server-side
auto_apply_maskis disabled. Whole masked frames now pass through so callers can still manuallyframe.unmask(), while fragmented masked text/binary frames are unmasked per fragment before accumulation because the final aggregate cannot carry per-fragment mask keys.Frame::unmask()also clears the mask key after applying it so auto-unmasked frames are no longer treated as masked later.Tests cover unfragmented manual unmasking plus fragmented masked text and binary through an in-memory websocket stream.
Refs #103
Closes denoland/divybot#513