feat: enable text imports by default

lib/lib.rs

@@ -312,7 +312,6 @@ pub async fn js_create_graph(
         is_dynamic: false,
         skip_dynamic_deps: false,
         unstable_bytes_imports: true,
-        unstable_text_imports: true,
         resolver: maybe_resolver.as_ref().map(|r| r as &dyn Resolver),
         // todo(dsherret): actually implement this for Wasm users
         // and don't just use a RealSys here as it would be better

src/graph.rs

@@ -1692,8 +1692,6 @@ pub struct BuildOptions<'a> {
   pub skip_dynamic_deps: bool,
   /// Support unstable bytes imports.
   pub unstable_bytes_imports: bool,
-  /// Support unstable text imports.
-  pub unstable_text_imports: bool,
   pub executor: &'a dyn Executor,
   pub locker: Option<&'a mut dyn Locker>,
   pub file_system: &'a FileSystem,
@@ -1717,7 +1715,6 @@ impl Default for BuildOptions<'_> {
       is_dynamic: false,
       skip_dynamic_deps: false,
       unstable_bytes_imports: false,
-      unstable_text_imports: false,
       executor: Default::default(),
       locker: None,
       file_system: &NullFileSystem,
@@ -4557,7 +4554,6 @@ struct Builder<'a, 'graph> {
   skip_dynamic_deps: bool,
   was_dynamic_root: bool,
   unstable_bytes_imports: bool,
-  unstable_text_imports: bool,
   file_system: &'a FileSystem,
   jsr_url_provider: &'a dyn JsrUrlProvider,
   jsr_version_resolver: Cow<'a, JsrVersionResolver>,
@@ -4591,7 +4587,6 @@ impl<'a, 'graph> Builder<'a, 'graph> {
       skip_dynamic_deps: options.skip_dynamic_deps,
       was_dynamic_root: options.is_dynamic,
       unstable_bytes_imports: options.unstable_bytes_imports,
-      unstable_text_imports: options.unstable_text_imports,
       file_system: options.file_system,
       jsr_url_provider: options.jsr_url_provider,
       jsr_version_resolver: options.jsr_version_resolver,
@@ -5347,10 +5342,11 @@ impl<'a, 'graph> Builder<'a, 'graph> {
         );
         return;
       }
+
       if let Some(attribute) = &options.maybe_attribute_type {
         let is_allowed = match attribute.kind.as_str() {
           "bytes" => self.unstable_bytes_imports,
-          "text" => self.unstable_text_imports,
+          "text" => true,
           _ => false,
         };
         if !is_allowed {

tests/ecosystem_test.rs

@@ -297,7 +297,6 @@ async fn test_version(
         is_dynamic: false,
         skip_dynamic_deps: false,
         unstable_bytes_imports: false,
-        unstable_text_imports: false,
         module_analyzer: &module_analyzer,
         module_info_cacher: Default::default(),
         file_system: &NullFileSystem,

tests/helpers/mod.rs

@@ -159,7 +159,6 @@ pub struct TestBuilder {
   workspace_members: Vec<WorkspaceMember>,
   workspace_fast_check: bool,
   unstable_bytes_imports: bool,
-  unstable_text_imports: bool,
 }
 
 impl TestBuilder {
@@ -178,7 +177,6 @@ impl TestBuilder {
       workspace_members: Default::default(),
       workspace_fast_check: false,
       unstable_bytes_imports: false,
-      unstable_text_imports: false,
     }
   }
 
@@ -262,12 +260,6 @@ impl TestBuilder {
     self
   }
 
-  #[allow(unused)]
-  pub fn unstable_text_imports(&mut self, value: bool) -> &mut Self {
-    self.unstable_text_imports = value;
-    self
-  }
-
   #[allow(unused)]
   pub fn ensure_locker(&mut self) -> &mut Self {
     self.locker.get_or_insert_with(Default::default);
@@ -329,7 +321,6 @@ impl TestBuilder {
           }),
           skip_dynamic_deps: self.skip_dynamic_deps,
           unstable_bytes_imports: self.unstable_bytes_imports,
-          unstable_text_imports: self.unstable_text_imports,
           jsr_version_resolver: Cow::Owned(JsrVersionResolver {
             newest_dependency_date_options: self.newest_dependency_date.clone(),
           }),

tests/specs/ecosystem/hampus/itsdangerous/1_1_0.test

@@ -24,36 +24,6 @@ hampus/itsdangerous/1.1.0
 -- stdout --
 
 -- stderr --
-TS2304 [ERROR]: Cannot find name 'BufferEncoding'.
-export function wantBuffer(string: StringBuffer, encoding?: BufferEncoding): Buffer {
-                                                            ~~~~~~~~~~~~~~
-    at file://<tmpdir>/src/encoding.ts:2:61
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-export function wantBuffer(string: StringBuffer, encoding?: BufferEncoding): Buffer {
-                                                                             ~~~~~~
-    at file://<tmpdir>/src/encoding.ts:2:78
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-export function base64Encode(string: StringBuffer): Buffer {
-                                                    ~~~~~~
-    at file://<tmpdir>/src/encoding.ts:5:53
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-export function base64Decode(string: StringBuffer): Buffer {
-                                                    ~~~~~~
-    at file://<tmpdir>/src/encoding.ts:8:53
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-export function intToBuffer(num: number | bigint): Buffer {
-                                                   ~~~~~~
-    at file://<tmpdir>/src/encoding.ts:11:52
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-export function bufferToInt(buf: Buffer): number | bigint {
-                                 ~~~~~~
-    at file://<tmpdir>/src/encoding.ts:14:34
-
 TS1205 [ERROR]: Re-exporting a type when 'isolatedModules' is enabled requires using 'export type'.
 export { DefaultSerializer, Serializer, SerializerOptions } from "./serializer.ts";
          ~~~~~~~~~~~~~~~~~
@@ -69,152 +39,7 @@ export { HMACAlgorithm, KeyDerivation, NoneAlgorithm, Signer, SignerOptions, Sig
                                                               ~~~~~~~~~~~~~
     at file://<tmpdir>/src/index.ts:4:63
 
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-   */ declare secretKeys: Buffer[];
-                          ~~~~~~
-    at file://<tmpdir>/src/serializer.ts:52:27
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  declare salt: Buffer;
-                ~~~~~~
-    at file://<tmpdir>/src/serializer.ts:53:17
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-   */ parsePayload(payload: Buffer, serializer?: DefaultSerializer): any {
-                            ~~~~~~
-    at file://<tmpdir>/src/serializer.ts:64:29
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-   */ stringifyPayload(obj: any): Buffer {
-                                  ~~~~~~
-    at file://<tmpdir>/src/serializer.ts:70:35
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  getSignature(_key: Buffer, _value: Buffer): Buffer {
-                     ~~~~~~
-    at file://<tmpdir>/src/signer.ts:7:22
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  getSignature(_key: Buffer, _value: Buffer): Buffer {
-                                     ~~~~~~
-    at file://<tmpdir>/src/signer.ts:7:38
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  getSignature(_key: Buffer, _value: Buffer): Buffer {
-                                              ~~~~~~
-    at file://<tmpdir>/src/signer.ts:7:47
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  verifySignature(key: Buffer, value: Buffer, sig: Buffer): boolean {
-                       ~~~~~~
-    at file://<tmpdir>/src/signer.ts:10:24
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  verifySignature(key: Buffer, value: Buffer, sig: Buffer): boolean {
-                                      ~~~~~~
-    at file://<tmpdir>/src/signer.ts:10:39
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  verifySignature(key: Buffer, value: Buffer, sig: Buffer): boolean {
-                                                   ~~~~~~
-    at file://<tmpdir>/src/signer.ts:10:52
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  override getSignature(_key: Buffer, _value: Buffer): Buffer {
-                              ~~~~~~
-    at file://<tmpdir>/src/signer.ts:18:31
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  override getSignature(_key: Buffer, _value: Buffer): Buffer {
-                                              ~~~~~~
-    at file://<tmpdir>/src/signer.ts:18:47
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  override getSignature(_key: Buffer, _value: Buffer): Buffer {
-                                                       ~~~~~~
-    at file://<tmpdir>/src/signer.ts:18:56
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  override getSignature(key: Buffer, value: Buffer): Buffer {
-                             ~~~~~~
-    at file://<tmpdir>/src/signer.ts:33:30
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  override getSignature(key: Buffer, value: Buffer): Buffer {
-                                            ~~~~~~
-    at file://<tmpdir>/src/signer.ts:33:45
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  override getSignature(key: Buffer, value: Buffer): Buffer {
-                                                     ~~~~~~
-    at file://<tmpdir>/src/signer.ts:33:54
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-   */ declare secretKeys: Buffer[];
-                          ~~~~~~
-    at file://<tmpdir>/src/signer.ts:88:27
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  declare sep: Buffer;
-               ~~~~~~
-    at file://<tmpdir>/src/signer.ts:89:16
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  declare salt: Buffer;
-                ~~~~~~
-    at file://<tmpdir>/src/signer.ts:90:17
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-   */ deriveKey(secretKey?: StringBuffer): Buffer {
-                                           ~~~~~~
-    at file://<tmpdir>/src/signer.ts:103:44
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-   */ getSignature(value: StringBuffer): Buffer {
-                                         ~~~~~~
-    at file://<tmpdir>/src/signer.ts:108:42
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-   */ sign(value: StringBuffer): Buffer {
-                                 ~~~~~~
-    at file://<tmpdir>/src/signer.ts:113:34
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-   */ unsign(signedValue: StringBuffer): Buffer {
-                                         ~~~~~~
-    at file://<tmpdir>/src/signer.ts:123:42
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-   */ override sign(value: StringBuffer): Buffer {
-                                          ~~~~~~
-    at file://<tmpdir>/src/timed.ts:21:43
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-   */ override unsign(signedValue: StringBuffer, maxAge?: number, returnTimestamp?: false): Buffer;
-                                                                                            ~~~~~~
-    at file://<tmpdir>/src/timed.ts:29:93
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  override unsign(signedValue: StringBuffer, maxAge?: number, returnTimestamp?: true): [Buffer, Date];
-                                                                                        ~~~~~~
-    at file://<tmpdir>/src/timed.ts:30:89
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-export type StringBuffer = string | Buffer;
-                                    ~~~~~~
-    at file://<tmpdir>/src/types.ts:1:37
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  override parsePayload(payload: Buffer, serializer?: DefaultSerializer): any {
-                                 ~~~~~~
-    at file://<tmpdir>/src/url-safe.ts:9:34
-
-TS2591 [ERROR]: Cannot find name 'Buffer'.
-  override stringifyPayload(obj: any): Buffer {
-                                       ~~~~~~
-    at file://<tmpdir>/src/url-safe.ts:12:40
-
-Found 38 errors.
+Found 3 errors.
 
 error: Type checking failed.