fix(jupyter): support IPC connection files#35202
Open
quillaid wants to merge 1 commit into
Open
Conversation
Deno Individual Contributor License AgreementThe following contributors need to sign the CLA before this PR can be merged: Click here to review and sign the CLA | Re-run CLA check This is an automated message from CLA Assistant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transporttoipc.<ip>-<port>convention.ipc://...endpoints and add Unix-only IPC coverage for heartbeat andkernel_info_reply.Validation
./tools/format.js cli/js/jupyter_kernel.js tests/integration/jupyter_client.rs tests/integration/jupyter_tests.rspassed before the host cleanup.git diff --checkpassed.target/debug/denofor the targeted integration test was stopped because host disk pressure dropped free space below 8G while Denotarget/grew large. No further local Deno build/test was run after cleanup.Closes #35201
Disclosure: this PR was AI-assisted.