fix(test): expect legacy-abort deprecation warning in request_signal_streaming#35191
Closed
divybot wants to merge 1 commit into
Closed
fix(test): expect legacy-abort deprecation warning in request_signal_streaming#35191divybot wants to merge 1 commit into
divybot wants to merge 1 commit into
Conversation
…streaming The `serve::request_signal_streaming` spec test (added in #35049) and the legacy-abort deprecation warning (added in #34397) landed in parallel and collided on main: the test exercises legacy abort with a handler that accesses `request.signal` and returns successfully, which is exactly the case #34397 now warns about. Neither PR saw the other, so main has been failing `test specs ... request_signal_streaming` on every commit since #34397. The warning is correct and expected for this scenario, so update the test's expected output to include it. Verified the warning is emitted deterministically as the first line.
This was referenced Jun 13, 2026
littledivy
pushed a commit
that referenced
this pull request
Jun 13, 2026
…streaming This test (added in #35049) and the legacy-abort deprecation warning (added in #34397) landed in parallel and collided on main: the test exercises legacy abort with a handler that accesses request.signal and returns successfully, which is exactly what #34397 warns about, but its main.out wasn't updated. main has been failing this spec test on every commit since #34397, which blocks CI for this PR (and every other) once merged with main. The warning is correct for this scenario, so expect it in the test output. Folded in here (rather than the standalone #35191) to make this PR's CI self-sufficient; happy to split back out if preferred.
Contributor
Author
|
Folding this into #35133 (the publish PR) so that PR's CI is self-sufficient and doesn't have to wait on this one to merge first. The fix is identical — updating |
littledivy
pushed a commit
that referenced
this pull request
Jun 13, 2026
…ming Merging main brings in #34397, which emits a legacy-abort deprecation warning when a Deno.serve handler uses legacy request.signal abort on a successful response. The request_signal_streaming spec exercises exactly that path, so its expected output must include the warning line. Same fix as the closed #35191 (folded into #35133); included here so this PR's CI is self-sufficient. Unrelated to the blob-worker change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test specs ... serve::request_signal_streamingis currently failing on everymaincommit since #34397 landed. Example: it fails on the latestmain(69de4f41e4) and on the 6 commits before it, back to #34397 itself.This is a semantic merge conflict between two PRs that landed in parallel:
serve/request_signal_streamingspec test, whosemain.outexpects only the program output.request.signal, and the request completes successfully.The test exercises exactly that scenario (it reads
req.signal.abortedand adds anabortlistener, then returns a successful streaming response), so the new warning is now printed to stderr and the captured output no longer matchesmain.out. Neither PR's CI saw the other's change.Fix
The warning is correct and intended for this case, so update the test's expected output to include it. The warning is emitted deterministically as the first line (verified across repeated runs).
Verification
This unblocks
test specs (…) debugfor all open PRs (it currently fails for every PR that merges withmain).