Fix filtering of import-tree and explicit files in path - #42
Merged
Conversation
jbgi
force-pushed
the
fix-file-root-relative-path
branch
from
September 2, 2026 15:46
71fa566 to
740827e
Compare
Root files (file explicitely listed in roots) where filtered based on their full path, so they could easily be filtered out if located in a 'hidden' directory. Fix this by always including a file if its listed in roots. For import-tree in path, use the foreign import-tree api for filtering as this is the only way to handle relative path sanely. Globally simplified the filtering pass, probably improving performance.
jbgi
force-pushed
the
fix-file-root-relative-path
branch
from
September 3, 2026 09:03
740827e to
5bb067e
Compare
jbgi
changed the title
vic
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root files (file explicitely listed in roots) where
filtered based on their full path, so they could
easily be filtered out if located in a 'hidden'
directory.
Fix this by always including a file if its listed in roots.
For import-tree in path, use the foreign import-tree api for filtering
as this is the only way to handle relative path sanely.
Globally simplified the filtering pass, probably improving performance.