feat: make result return lambda to allow direct use with type.submodule - #40
Merged
Conversation
vic
approved these changes
Aug 31, 2026
vic
requested changes
Aug 31, 2026
vic
left a comment
vic
left a comment
Member
There was a problem hiding this comment.
looks good, please fix PR conflicts.
ie. implement workaround in NixOS/nixpkgs#377575 (comment) this also remove one level of module nesting, so could be seen as a simplification too. Fix failing test introduced in previous commit.
jbgi
force-pushed
the
fix-submodule-use
branch
from
September 1, 2026 09:43
493e609 to
0b1a893
Compare
vic
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ie. implement workaround described in NixOS/nixpkgs#377575 (comment)
This also remove one level of module nesting, so could be seen as a simplification too.
Fix failing test introduced in previous commit.