feat: improve scopedImport with _file attribute and scoped in builtins - #39
Merged
Conversation
jbgi
force-pushed
the
scopedImport-improvements
branch
from
August 26, 2026 15:49
4eb89bd to
c75b714
Compare
sini
self-requested a review
August 26, 2026 16:05
vic
requested changes
Aug 31, 2026
vic
left a comment
vic
left a comment
Member
There was a problem hiding this comment.
We have a few tests for scoped.* can you please add some tests exercising the changes here ? builtins.scoped being correctly set and builtins.nixPath ?
Code looks good.
also properly override builtins.nixPath in addition to __nixPath.
even if scope include a builtins attribute set. Also allows to explicitly set nixPath via scope.
jbgi
force-pushed
the
scopedImport-improvements
branch
from
September 1, 2026 11:10
c75b714 to
ef94a80
Compare
Contributor
Author
|
@vic tests added. Also added a last commit to improve consitancy when provided scope include a |
vic
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_filefor proper error reportingbuiltins.scopedfor potential reuse of scoped variable in nested invocations (see example in doc).__nixPathwas overriden but notbuiltins.nixPath: fixed that.