improve heuristic for detecting if curried - #36
Merged
Conversation
This adds a check that ensures it is either a native function or an attribute set that only has __functor and/or __functionArgs attributes
Member
thanks, but any change here must not depend on being tested in den, some people use flake-aspects without den, we have tests in this repo see checkmate dir, please add tests there |
Contributor
Author
|
Ok, added a test for this. Lmk if this is good enough. |
Member
|
Awesome! thank you so much :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a check that ensures a curried function is either a native function or an attribute set that only has
__functorand/or__functionArgsattributes.I've tested it by running all the tests at https://github.com/vic/den/blob/main/templates/ci. Let me know if this looks sound.