Sprint 8 solution time and duration#5
Merged
Conversation
…ерки наложения задач по времени.
| public ArrayList<Subtask> getEpicSubtask(Integer epicId) { //Выводит список подзадач эпика | ||
| ArrayList<Subtask> currentEpic = new ArrayList<>(); | ||
| public List<Subtask> getEpicSubtask(Integer epicId) { //Выводит список подзадач эпика | ||
| /*List<Subtask> currentEpic = new ArrayList<>(); |
There was a problem hiding this comment.
Закомментированный код убираем из работы на проверку
| @@ -59,7 +68,7 @@ public void deleteAllSubtask() { | |||
| } | |||
There was a problem hiding this comment.
Также удалить из prioritizedTasks. Аналогично для deleteTaskList
| } | ||
|
|
||
| @Test | ||
| void createTask() { |
There was a problem hiding this comment.
В юнит тестах есть несколько соглашений по именованию методов. Предлагаю воспользоваться одним из них
https://gist.github.com/badarahmed/ef020400467d9bb61e31
VadimZharkov
suggested changes
Sep 17, 2025
VadimZharkov
left a comment
VadimZharkov
left a comment
There was a problem hiding this comment.
В целом подход к реализации верный. Нужно исправить замечания, также оставил одну рекомендацию.
VadimZharkov
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавлена возможность создавать Задачи и Подзадачи с Датой и Временем.
Предусмотрена невозможность коллизии по дате при создании и добавлении задач.
Некоторые методы переписаны с учетом ФП и новой функциональности.
Добавлены новые тесты и переписаны некоторые старые под новую функциональность.