Sprint 6 solution#3
Merged
Merged
Conversation
| head.prev = null; | ||
| } | ||
| } | ||
| } else { |
There was a problem hiding this comment.
else лишний, т.к. итак конец метода и будет выход
| } | ||
|
|
||
| private void removeNode(int id) { | ||
| if (mapHistory.containsKey(id)) { //если история содержит элемент с id нужно для удаления |
There was a problem hiding this comment.
Вместо mapHistory.containsKey(id) можно сразу
final Node node = mapHistory.remove(id);
if (node == null) {
return;
}
VadimZharkov
suggested changes
Aug 15, 2025
VadimZharkov
left a comment
VadimZharkov
left a comment
There was a problem hiding this comment.
Хорошая работа. В целом все верно. Оставил пару рекомендаций.
Owner
Author
|
Благодарю за ревью, внес правки согласно рекомендациям. |
VadimZharkov
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Переписан функционал менеджера историй под самописный двухсвязанный список + HashMap.
Изменен менеджер задач под работу с новыми функциями менеджера историй, добавлен метод удаления всей истории, также внесены исправления для корректной работы тестов с доп задания.
В классе main появились доп проверки нового функционала в том числе проверки доп задания.
Также были переоформлены и дополнены классы с тестами с учетом нового функционала.