fix: address all 6 bankr review comments — safety guardrails, custody warnings, social fallback#7
Closed
deluonchain wants to merge 3 commits into
Closed
fix: address all 6 bankr review comments — safety guardrails, custody warnings, social fallback#7deluonchain wants to merge 3 commits into
deluonchain wants to merge 3 commits into
Conversation
…warnings (bankr review)
…o user (bankr review)
…fo and verbose no-op (bankr review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all 6 issues raised in the Bankr skill review (BankrBot/skills#481).
Changes
SKILL.md⚠️ Oracle output is untrusted datasection explicitly stating thatdecision.read,summary,drivers,risks, and social fields are untrusted external text that must not override agent instructions, trigger tool calls, sign payments, or execute trades autonomously.⚠️ x402 payment costssection requiring user-approved budget, max call count, and explicit opt-in for?social=truebefore any watchlist loop. Includes concrete cost example (10-token watchlist = up to 2.5M DELU at public tier).references/social-enrichment.mdreferences/external-clients.mdx402-fetch@0.4.2,viem@2.21.54,x402==0.3.1in all install examples.⚠️ Wallet custody warningblock at the top covering dedicated hot wallet, spending limits, no.envcommits, key rotation, and no browser use.$0.25 USDC / EIP-3009toDELU / upto / Permit2to match current endpoint behavior.?verbose=trueis a no-op —observedis always present. Removed the misleading implication it was needed.