fix: full signal renderer + schema alignment (entry_zone, invalidations, size_hint_pct, horizon)#4
Open
deluonchain wants to merge 2 commits into
Open
Conversation
…dations plural, size_hint_pct pct scale, horizon keys)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what this fixes
SKILL.md — renderer was missing 4 of 7 blocks
the old SKILL.md was a pure API spec with no rendering instructions. the agent was only rendering
verdict / score / confidence / summary / drivers / risks / mandateand skipping:new SKILL.md adds explicit rendering instructions with field-by-field output format, null-omission rules, and hard rules against skipping signal stack or context blocks.
references/mandate-fields.md — schema mismatches corrected
four bugs aligned to the live
internal_oracle.tsoutput:entry_zone{ low, high }object[low, high]arrayinvalidationinvalidations: string[]plural arraysize_hint_pct0.033.0, clamped[0.5, 10.0]horizonkeysh4_to_d1,scalp,h1_to_h44h-24h,1h-3h,1h-4hetc.horizon key table added for all regime labels.
backend patches still needed (bankr-fs internal_oracle.ts)
these are code changes required on the backend — not in this repo but documented here for tracking:
entry_zone: { low, high }→entry_zone: [low, high]invalidation: string→invalidations: string[](wrap in array, add liquidity condition)size_hint_pctclamp[0.005, 0.1]→[0.5, 10.0], base sizes0.05/0.03→5.0/3.0horizonForRegime()key strings fixed to match mandate-fields.md tablesanitize()leak scrubber:out.mandate?.invalidation→...(out.mandate?.invalidations ?? [])