Skip to content

Update property declaration syntax for Haxe 4 compatibility - #114

Open
Gama11 wants to merge 1 commit into
deltaluca:masterfrom
Gama11:haxe4
Open

Update property declaration syntax for Haxe 4 compatibility#114
Gama11 wants to merge 1 commit into
deltaluca:masterfrom
Gama11:haxe4

Conversation

@Gama11

@Gama11 Gama11 commented Sep 9, 2018

Copy link
Copy Markdown
Contributor

see HaxeFoundation/haxe#4699 - Haxe 4 removes support for the old Haxe 2 style property syntax, so trying to compile Nape with it leads to a bunch of errors:

C:/HaxeToolkit/haxe/lib/nape/2,0,20/nape/geom/Vec2.hx:641: characters 2-50 : length: Custom property accessor is no longer supported, please use set
C:/HaxeToolkit/haxe/lib/nape/2,0,20/nape/geom/Vec2.hx:921: characters 2-47 : angle: Custom property accessor is no longer supported, please use get
C:/HaxeToolkit/haxe/lib/nape/2,0,20/nape/geom/Vec2.hx:921: characters 2-47 : angle: Custom property accessor is no longer supported, please use set
C:/HaxeToolkit/haxe/lib/nape/2,0,20/nape/dynamics/ArbiterList.hx:248: characters 2-43 : length: Custom property accessor is no longer supported, please use get
C:/HaxeToolkit/haxe/lib/nape/2,0,20/nape/geom/Vec2List.hx:248: characters 2-43 : length: Custom property accessor is no longer supported, please use get
C:/HaxeToolkit/haxe/lib/nape/2,0,20/nape/constraint/Constraint.hx:197: characters 2-60 : userData: Custom property accessor is no longer supported, please use get
C:/HaxeToolkit/haxe/lib/nape/2,0,20/nape/constraint/Constraint.hx:224: characters 2-65 : compound: Custom property accessor is no longer supported, please use get

@deltaluca If you want to make a release right away, here's a .zip with an updated haxelib.json and rebuilt sources: 2,0,21.zip

@trethaller

Copy link
Copy Markdown

Cheers Jens, we're also using Nape here at Shiro 👍

@peteshand

Copy link
Copy Markdown

Would be great to have this deployed to haxelib!

@TomByrne

Copy link
Copy Markdown

+1 For getting this on Haxelib

@Gama11

Gama11 commented May 1, 2019

Copy link
Copy Markdown
Contributor Author

Since there's quite a few signs that Luca is no longer interested in maintaining Nape (no responses to issues, PRs or emails, the domain has expired...), I've created a fork and pushed it it to Haxelib.

So to get a Haxe 4 compatible version, you just have to replace the library name in your .hxml / project.xml with nape-haxe4 and run haxelib install nape-haxe4.

@peteshand

Copy link
Copy Markdown

nice one @Gama11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants