chore: clean up detekt baseline (124 → 12 issues)#231
Merged
Conversation
Code fixes: - Remove dead GameBootstrap.addCardToZone private method - Remove unused GameLoopController.onStateChanged param - Replace throw IllegalArgumentException with require() (DeckLoader, WebGuiGame) - Replace throw IllegalStateException with checkNotNull() (InteractivePromptBridge) - Use IllegalStateException instead of RuntimeException (GameBridge puzzle apply) - Log swallowed exception in InteractivePromptBridge catch block - Comment out unused isSendAndRecord val in InvariantChecker (TODO code) Suppressions with reasons: - Unused loggers kept for future use (@Suppress on property) - Visitor pattern ReturnCount, protocol dispatch CyclomaticComplexMethod - Wire-format ConstructorParameterNaming (CardsBlob) - LobbyStubs FunctionOnlyReturningConstant (intentional protocol stubs) - MaxLineLength in test JSON assertions and debug prints - UnusedParameter where interface/override contracts require the signature - SwallowedException where cause IS forwarded (GameBridge, DebugServer) Remaining 12 baseline issues are real refactors (LongMethod, LongParameterList) that need separate work to extract helpers / introduce param objects.
CI Report — GateTests: 825/825 passed (190 skipped) Coverage: 11.0% (642/5861 lines)
Slow tests (>3s): 1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
Summary
Reduces detekt baseline from 124 → 12 unsuppressed issues. The remaining 12 are real refactors (long methods, long parameter lists) that need separate work.
Code fixes (~15 issues removed)
GameBootstrap.addCardToZoneprivate methodGameLoopController.onStateChangedconstructor paramthrow IllegalArgumentExceptionwithrequire()(DeckLoader, WebGuiGame)throw IllegalStateExceptionwithcheckNotNull()(InteractivePromptBridge)IllegalStateExceptioninstead ofRuntimeException(GameBridge puzzle apply)isSendAndRecordval (InvariantChecker TODO code)Suppressions with reasons (~85 issues → ManuallySuppressedIssues)
Remaining 12 (deferred)
LongMethod: ActionMapper, MatchSession, StateMapper, WebCostDecision, RecordingCliLongParameterList: GsmBuilder, ZoneMapper, FrontDoorHandler, SemanticTimelineTestUnusedParameter: MatchmakingService.playerIdAll 796 tests pass. Detekt + spotless clean.