docs(matchdoor): persistent annotation lifecycle KDoc#230
Merged
Conversation
…g invariants Enriches KDoc on PersistentAnnotationStore with the full lifecycle (create/carry-forward/replace-on-update/delete/drain), computeBatch step ordering invariant, snapshot timing constraint, and threading contract. Adds invisible-constraint comments on applyBatchResult and drainDeletions. Cross-references from GameBridge and StateMapper. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
CI Report — GateTests: 825/825 passed (190 skipped) Coverage: 11.0% (642/5861 lines)
Slow tests (>3s): 1
|
…; add kdoc-enrich skill WebPlayerController: documents threading model (every override runs on engine thread, blocks via CompletableFuture), chooseSpellAbilityToPlay as game loop entry point, playChosenSpellAbility deadlock constraint, and cross-class flag contracts (searchedToHandCards, legendRuleVictims, stashedOptionalCostIndices) with InteractivePromptBridge. GameEventCollector: documents drain-once-per-GSM contract (double-drain silently loses events), event ordering vs annotation ordering distinction, and cross-class flag consumption from WebPlayerController via PromptBridge. Adds kdoc-enrich skill with process, decision criteria, and candidates backlog for future enrichment sessions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PersistentAnnotationStoreclass KDoc with the full persistent annotation lifecycle: create (4 sources in fixed order), carry-forward, replace-on-update (counter upsert), delete (5 reasons), drain-once-per-GSM semanticscomputeBatchordering invariant (steps 1→6 fixed order) and snapshot timing constraintapplyBatchResult(must run after GSM assembly) anddrainDeletions(Full vs Diff distinction)GameBridge.annotationsandStateMappersnapshot/apply sites back to the store KDocFollows documentation principles: KDoc at the seam (principles #1, #4), invisible constraints documented (principle #3), no standalone doc needed.
Test plan
just fmt)🤖 Generated with Claude Code