Conversation
Contributor
|
@ArjunR00T is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
ttlsupport toCacheCheckerfor cache expiration.time_field, defaulting tocached_at, for determining the cache timestamp.ttl=None.How did you test it?
hatch run test:unit test/components/caching/hatch run test:typestest/dataclasses/test_byte_stream.py::test_from_file_path_guess_mime_type[spam.csv-expected_mime_types10]because
application/vnd.ms-excelwas detected instead of the expectedtext/csv.Notes for the reviewer
The TTL check only applies when
ttlis configured. Whenttl=None, the existing cache-hit behavior is preserved.When TTL is configured, documents without the configured timestamp metadata field or with an expired timestamp are treated as cache misses.
Checklist
feat: add TTL support to CacheChecker.