fix: read _sockets_dict in Sockets.__getattribute__ - #12966
bhaskargurram-ai wants to merge 1 commit into
Conversation
__getattribute__ looked up a `_sockets` attribute, but the one __init__ assigns is `_sockets_dict`. The lookup raised AttributeError on every attribute access and fell through to object.__getattribute__, so the intended fast path never ran. Socket access still worked, but only through the copy __init__ places in __dict__ -- which made the dead branch look load-bearing and put an exception on the path of every attribute access. Reading the right name makes the branch live: 200k socket attribute accesses drop from 0.125s to 0.031s. External behaviour is unchanged, since the __dict__ copy already shadowed class attributes for the same names. Fixes deepset-ai#12939
|
@bhaskargurram-ai is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
Hi @bhaskargurram-ai, thanks a lot for your contribution! 🙏 We noticed that the Contributor License Agreement (CLA) check ( To get your PR reviewed, please sign the CLA via the link in the |
HaystackBot
added
the
cla-pending
HaystackBot
removed
the
cla-pending
|
Thanks for signing the CLA, @bhaskargurram-ai! 🎉 This PR is now ready for review again and the reviewer has been re-assigned. |
This branch has not been deployed
3 participants
getattribute looked up a
_socketsattribute, but the one init assigns is_sockets_dict. The lookup raised AttributeError on every attribute access and fell through to object.getattribute, so the intended fast path never ran.Socket access still worked, but only through the copy init places in dict -- which made the dead branch look load-bearing and put an exception on the path of every attribute access.
Reading the right name makes the branch live: 200k socket attribute accesses drop from 0.125s to 0.031s. External behaviour is unchanged, since the dict copy already shadowed class attributes for the same names.
Fixes #12939
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.