Repository navigation
fix: do not mutate caller-provided client_kwargs in LinkContentFetcher - #12880
burakeyler wants to merge 1 commit into
Conversation
|
@burakeyler is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Signed-off-by: Burak Eyler <burakeyler@gmail.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Hi @burakeyler, thanks for your interest in contributing to Haystack! 🙏 This is an automated message to help us keep the review queue healthy. |
|
Hi @burakeyler, thanks for your interest in contributing to Haystack! 🙏 ⛔ First-time contributors can have at most 1 open pull request in this repository until it has been approved, so this PR was closed automatically. Your open pull request #12879 is unaffected. Once it has been approved by a maintainer, you are welcome to open more PRs. Feel free to reopen this one at that point. See the contributing guidelines for details. This is an automated message to help us keep the review queue healthy. |
Related Issues
Fixes #12828
Proposed Changes
LinkContentFetcher.__init__stored the caller'sclient_kwargsdictionary and then calledsetdefaulton it, so constructing the component addedtimeoutandfollow_redirectsto a dictionary the application owns. Sharing one HTTP-client configuration between components leaked Haystack's defaults into the later use.The dictionary is now shallow-copied before the defaults are applied.
How did you test it?
Added
test_init_does_not_mutate_client_kwargs, which fails onmainand passes here, and checked that the component still receives both defaults.pytest test/components/fetchers/test_link_content_fetcher.py -m "not integration"→ 27 passed.Checklist
🤖 Generated with Claude Code