packaging: add Arch forkd-bin recipe - #276
Conversation
ab442c3 to
6fe9c57
Compare
|
Pre-review notes while this is still a draft — no formal review yet. Thanks for the unusually complete validation section; it made checking this much faster. Verified independently
Please split this into two PRsThe Bundling them means users wait for the packaging review to get the fix. Suggest landing the The systemd syscall-filter change needs its own justification-SystemCallFilter=@system-service
-SystemCallFilter=~@privileged @resources
+SystemCallFilter=@system-service @mount
+SystemCallFilter=~@resourcesThe new comment explains why Two things make this worth pausing on:
Related: this file's own convention is to document each relaxation inline — see the Release ordering
Smaller things
Follow-up worth filing separately
|
6fe9c57 to
5b3cbc3
Compare
|
Thanks for the detailed pre-review. I split and rebased the work directly on
I also narrowed the generated package unit after testing the actual failure under systemd. Revalidation covered a clean The SIGHUP/audit-log follow-up is useful, but I kept it out of this packaging PR as suggested. |
|
The split and the syscall narrowing both look right. I checked the narrowing against systemd's own table rather than reasoning about it, since that was the part I asked you to justify.
The union of your two deny lines is exactly that set minus Also re-verified after the rebase:
Encoding the boundary in One optional nit, take it or leave it: a new distro package is arguably user-visible enough for a line under Nothing else outstanding from my side. #277 is approved and going in first; this one is fine to land whenever. |
Summary
forkd-binrecipe for the official v0.5.3 releasefirecrackerpackage instead of bundling oneThe recipe patches the tag-pinned v0.5.3 unit only. The in-repo systemd unit is unchanged.
The service patch gives the controller access to its rootfs cache and permits the three syscalls observed for
ip netns exec:mount,umount2, andcapset. The existing@system-serviceallowlist remains; the explicit deny list mirrors@privilegedexcept for requiredcapset, avoiding exposure of the full@mountgroup.Validation
makepkg --cleanbuild --force --noconfirmmakepkg.SRCINFOregenerated fromPKGBUILDbash -n packaging/arch/PKGBUILDsystemd-analyze verify /usr/lib/systemd/system/forkd-controller.servicepacman -Qkk forkd-bin firecracker: 0 altered filesforkd-bin 0.5.3-11.16.1-1.1/usr/bin/forkd-controller/tmpstate and exited 0docs/superpowers/**pathsScope
This PR now contains packaging files only. The MCP compatibility fix requested in #275 is split into a separate focused PR.