fix(cve): CVE-2026-7246 - Document and fix command string sanitizing with - #3
Merged
Conversation
…with CVE: CVE-2026-7246 (high) - Pallets Click, versions 8.3.2 and below, contain a command injection vulnerability in the click.edit() function, allowing attackers to pass arbitrary OS commands from an unprivileged account. Upstream: pallets/click@b96c260 Co-authored-by: hudeng <hudeng@deepin.org> Generated-By: qwen3.6-35b
|
TAG Bot TAG: 8.1.6-1deepin1 |
The CVE-2026-7246 patch moved shlex, shutil, and subprocess imports to module level in _termui_impl.py but omitted tempfile. The _tempfilepager function uses tempfile.mkstemp() with its local import removed, causing a NameError when called directly (e.g. in test_pager_uses_list_args). Add `import tempfile` to the module-level imports to fix the build failure. Log: Fix NameError by adding missing tempfile module-level import Influence: 1. Run test_pager_uses_list_args to verify _tempfilepager works 2. Run full test_termui.py suite to check for regressions 3. Verify package builds successfully with dpkg-buildpackage 4. Confirm CVE-2026-7246 shell injection fix remains intact fix: 修复 _tempfilepager 中缺少 tempfile 导入导致的 NameError CVE-2026-7246 补丁将 shlex、shutil、subprocess 导入移至模块级别， 但遗漏了 tempfile。_tempfilepager 函数使用 tempfile.mkstemp() 且其 局部导入已被移除，导致直接调用时抛出 NameError（如 test_pager_uses_list_args）。 在模块级导入中添加 `import tempfile` 以修复编译失败。 Log: 添加缺失的 tempfile 模块级导入以修复 NameError Influence: 1. 运行 test_pager_uses_list_args 验证 _tempfilepager 正常工作 2. 运行完整 test_termui.py 测试套件检查回归 3. 验证 dpkg-buildpackage 构建成功 4. 确认 CVE-2026-7246 shell 注入修复仍然有效 repo: python-click #fix-cve/CVE-2026-7246
Contributor
|
/integrate |
|
AutoIntegrationPr Bot |
Contributor
|
/approve |
Contributor
Author
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hudeng-go The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CVE: CVE-2026-7246 (high) - Pallets Click, versions 8.3.2 and below, contain a command injection vulnerability in the click.edit() function, allowing attackers to pass arbitrary OS commands from an unprivileged account.
Upstream: pallets/click@b96c260
Co-authored-by: hudeng hudeng@deepin.org
Generated-By: qwen3.6-35b