fix(reapply): add PRESERVE_DHCP reapply flag to skip DHCP restart - #26
Conversation
When switching primary connection by toggling never-default via reapply,the DHCP client was unnecessarily restarted, causing a lease renegotiation that blocked the switch for several seconds. With PRESERVE_DHCP flag set, the reapply path keeps the DHCP client alive and only updates the l3cd merge-flags, so default routes are correctly filtered without touching DHCP. - Add NM_DEVICE_REAPPLY_FLAGS_PRESERVE_DHCP (0x2) to NMDeviceReapplyFlags enum - Skip DHCP cleanup/start in _dev_ipdhcpx_cleanup when preserve_dhcp is set - Re-register existing l3cds after MANUALIP rebuild to propagate updated merge-flags (including NO_DEFAULT_ROUTES) to DHCP/LL/AC l3cds - Add debug logging for reapply preserve-dhcp flow 通过reapply切换never-default来切换主连接时，DHCP客户端会被不必要地重启， 导致租约重新协商，阻塞切换数秒。设置PRESERVE_DHCP标志后，reapply路径会保持DHCP客户端存活，仅更新l3cd的merge-flags，从而在不触碰DHCP的情况下正确过滤默认路由。 - 新增 NM_DEVICE_REAPPLY_FLAGS_PRESERVE_DHCP (0x2) 到 NMDeviceReapplyFlags 枚举 - 在 _dev_ipdhcpx_cleanup 中当 preserve_dhcp 设置时跳过DHCP清理/启动 - 在MANUALIP重建后重新注册已有的l3cd，将更新的merge-flags（包括NO_DEFAULT_ROUTES）传播到DHCP/LL/AC l3cd - 添加reapply preserve-dhcp流程的调试日志 PMS: BUG-351163
|
TAG Bot TAG: 1.44.2-7deepin10 |
|
Hi @ut003640. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/forcemarge |
|
/merge |
|
Merge" command is disabled |
|
/forcemerge |
4 participants
When switching primary connection by toggling never-default via reapply,the DHCP client was unnecessarily restarted, causing a lease renegotiation that blocked the switch for several seconds. With PRESERVE_DHCP flag set, the reapply path keeps the DHCP client alive and only updates the l3cd merge-flags, so default routes are correctly filtered without touching DHCP.
通过reapply切换never-default来切换主连接时，DHCP客户端会被不必要地重启， 导致租约重新协商，阻塞切换数秒。设置PRESERVE_DHCP标志后，reapply路径会保持DHCP客户端存活，仅更新l3cd的merge-flags，从而在不触碰DHCP的情况下正确过滤默认路由。
PMS: BUG-351163