Skip to content

[Deepin-Kernel-SIG] [linux 6.6.y] [Hygon] EDAC/amd64: format hygon_get_umc_base#1632

Merged
opsiff merged 1 commit intodeepin-community:linux-6.6.yfrom
opsiff:linux-6.6.y-2026-04-16-hygon
Apr 16, 2026
Merged

[Deepin-Kernel-SIG] [linux 6.6.y] [Hygon] EDAC/amd64: format hygon_get_umc_base#1632
opsiff merged 1 commit intodeepin-community:linux-6.6.yfrom
opsiff:linux-6.6.y-2026-04-16-hygon

Conversation

@opsiff
Copy link
Copy Markdown
Member

@opsiff opsiff commented Apr 16, 2026

Summary by Sourcery

Enhancements:

  • Reformat hygon_get_umc_base to use consistent tab-based indentation without changing behavior.

Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 16, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR reformats the hygon_get_umc_base() helper in amd64_edac.c to use consistent tab-based indentation and kernel coding style, without changing its control flow or behavior.

File-Level Changes

Change Details Files
Normalize indentation and whitespace in hygon_get_umc_base() to match kernel coding style while preserving logic.
  • Replace space-based indentation with tabs for variable declarations, conditionals, and returns inside the function
  • Align comments and control structures with standard kernel formatting
  • Keep all conditional branches and function calls logically identical to the previous implementation
drivers/edac/amd64_edac.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Avenger-285714
Copy link
Copy Markdown
Member

/approve

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Avenger-285714

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@opsiff opsiff merged commit 6e29b26 into deepin-community:linux-6.6.y Apr 16, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants