feat(sandbox): isolate actions with Firecracker - #65
Open
Windsor Nguyễn (windsornguyen) wants to merge 1 commit into
Open
feat(sandbox): isolate actions with Firecracker#65Windsor Nguyễn (windsornguyen) wants to merge 1 commit into
Windsor Nguyễn (windsornguyen) wants to merge 1 commit into
Conversation
Windsor Nguyễn (windsornguyen)
requested review from
annyzhou and
Aryan Mahajan (aryanma)
August 12, 2026 06:34
Windsor Nguyễn (windsornguyen)
force-pushed
the
feat/firecracker-sandbox
branch
8 times, most recently
from
August 12, 2026 08:12
f319f8c to
1722eeb
Compare
Windsor Nguyễn (windsornguyen)
force-pushed
the
feat/firecracker-sandbox
branch
from
August 12, 2026 08:17
1722eeb to
f4d856a
Compare
This was referenced Aug 12, 2026
Shengming Liang (LiangShengming)
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #62.
What does this change?
This PR adds the local
untrusted-v1Firecracker executor. Thebuild,test, andruncommands accept--sandboxand execute admitted actions in new microVMs.The executor fails closed. It does not retry an incompatible or failed action on the host.
This profile supports only x86_64 Linux with KVM. It rejects networking, inherited host environments, persistent workers, output reuse, local resources, snapshots, VM reuse, secrets, custom devices, and remote execution.
How was it tested?
python3 test.py --ci --git --lint-rust-only.python3 test.py --ci --git --rustdoc-only.python3 test.py --git --test-only bsmr_sandbox bsmr_execute_impl bsmr_client bsmr_serverpassed 154 focused tests before the final boundary cases.cargo test -p bsmr_execute_impl executors::firecracker::testspassed 19 tests.cargo test --locked -p bsmr_sandboxcovered the launcher, guest, transport, fixed resources, and cleanup.cargo clippy -p bsmr_sandbox --target x86_64-unknown-linux-gnu --all-targets -- -D warnings.cargo build --locked --bin bsmr.pnpm run ci checkpassed 44 tests and the generation, provenance, license, and workflow-security checks.target/debug/bsmr docs markdown-help-doc allmatchesdocs/reference/cli.md.uv run --with-requirements docs/requirements.txt mkdocs build --strict -f mkdocs.yml.git diff --check chore/centralize-upstream-attribution...HEAD.The required
Rust / Firecracker sandboxjob is the real nested-KVM execution gate.VOUCHED.td.Reviewers