refactor(build): adopt BUILD.bsmr manifests - #40
Merged
Conversation
Dedalus (dedalus-ai)
approved these changes
Aug 6, 2026
Windsor Nguyễn (windsornguyen)
force-pushed
the
codex/build-manifest-name
branch
from
August 6, 2026 20:33
45633cb to
2395fb5
Compare
This was referenced Aug 6, 2026
Windsor Nguyễn (windsornguyen)
force-pushed
the
codex/build-manifest-name
branch
from
August 11, 2026 01:18
2395fb5 to
802830f
Compare
Dedalus (dedalus-ai)
approved these changes
Aug 11, 2026
Windsor Nguyễn (windsornguyen)
force-pushed
the
codex/build-manifest-name
branch
from
August 11, 2026 01:40
221431a to
4918f83
Compare
Dedalus (dedalus-ai)
approved these changes
Aug 11, 2026
Windsor Nguyễn (windsornguyen)
force-pushed
the
codex/build-manifest-name
branch
from
August 11, 2026 01:41
4918f83 to
dd4f193
Compare
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Windsor Nguyễn (windsornguyen)
force-pushed
the
codex/build-manifest-name
branch
from
August 11, 2026 01:52
dd4f193 to
5fba1e2
Compare
Dedalus (dedalus-ai)
approved these changes
Aug 11, 2026
Windsor Nguyễn (windsornguyen)
force-pushed
the
codex/build-manifest-name
branch
from
August 11, 2026 01:59
5fba1e2 to
86e11fe
Compare
1 task
1 task
Windsor Nguyễn (windsornguyen)
force-pushed
the
codex/build-manifest-name
branch
from
August 12, 2026 19:59
f90c746 to
c1fea72
Compare
Resolves RUSTSEC-2026-0253 (potential use-after-free due to lack of panic safety in LruCache::pop) flagged by the OSV dependency audit. The API surface we use (new, get, put, clear) is unchanged between 0.16.4 and 0.18.2. Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR makes
BUILD.bsmrthe default Bessemer package manifest.BUCK.v2andBUCKcandidate names.buildfile.name_v2setting.buildfile.nameto select another explicit name, such asTARGETS.bsmr init, and Reindeer now useBUILD.bsmr.BUCKpackage manifest.BUCK_TREEremains unchanged because it identifies a package modifier, not a package manifest.lrudependency uses version 0.18.2.The loader and manifest tree change together. An intermediate revision with only one change cannot load the repository.
How was it tested?
pnpm run ci check.cargo fmt --all -- --check.cargo test -p bsmr_common test_buildfiles.cargo build --locked --bin bsmr../tools/bin/reindeer --third-party-dir tools/build/third-party/rust buckify.target/debug/bsmr --isolation-dir=build-manifest-final targets 'bsmr_build//...'.BUILD.bsmrmanifests.BUCK,BUCK.v2,BUCK.fixture, orTARGETS.testmanifests.A self-hosted
//:bsmrbuild loads the migrated graph. It later fails in the generatedctor-1rule because the Rust action lacksCARGO_PKG_VERSION_*variables. This PR does not change that Reindeer behavior.VOUCHED.td.