fix(helm): allow externalSecret as valid DATABASE_URL source in postgres validation#3421
Merged
Merged
Conversation
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
database.engine=postgresqlandexternalSecret.enabled=true, the chart fails at render time:The validation only accepted
database.urlorsecret.secretNameas valid sources forDATABASE_URL, ignoring the case where the value comes from AWS Secrets Manager via ExternalSecret.Fix
Added
externalSecret.enabledas a third valid source. The check now passes when any of these is set:database.urlsecret.secretNameexternalSecret.enabled: trueRepublishes chart
0.7.0with the fix included.Summary by cubic
Fix Helm chart validation to accept
externalSecret.enabledas a validDATABASE_URLsource whendatabase.engine=postgresql, preventing render failures for ExternalSecret setups (e.g., AWS Secrets Manager). The chart now renders without requiringdatabase.urlorsecret.secretNamewhen ExternalSecret is used.Written for commit 78d3783. Summary will update on new commits. Review in cubic