feat(helm/studio): add opt-in ExternalSecret support for AWS Secrets Manager#3418
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…Manager When externalSecret.enabled=true, the chart creates a namespace-scoped SecretStore and an ExternalSecret using dataFrom so every key in the SM JSON becomes an env var automatically, with no per-key listing required. Backward compatible: disabled by default.
o-pauloroberto
force-pushed
the
feat/external-secret-support
branch
from
0e5d535 to
b5a99a1
Compare
…lict
- ExternalSecret target is now always the chart-managed name ({fullname}-secrets),
never secret.secretName — prevents silent takeover of existing Secrets
- Validation fails if both externalSecret.enabled=true and secret.secretName are set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
templates/externalsecret.yaml: whenexternalSecret.enabled=true, creates a namespace-scopedSecretStoreand anExternalSecretusingdataFrom— imports all keys from the Secrets Manager JSON at once, no per-key listing requiredtemplates/secret.yaml: updated condition to skip inline Secret creation whenexternalSecret.enabled=truevalues.yaml: newexternalSecretblock, disabled by default (enabled: false)Backward compatible — existing deployments are unaffected unless
externalSecret.enabled=trueis explicitly set.Usage
Test plan
externalSecret.enabled=trueand verify theExternalSecretsyncs and the Secret is created correctlyexternalSecret.enabledcontinue to work as before