fix(github-picker): show reconnect action on GitHub accounts error#3403
Open
guitavano wants to merge 1 commit into
Open
fix(github-picker): show reconnect action on GitHub accounts error#3403guitavano wants to merge 1 commit into
guitavano wants to merge 1 commit into
Conversation
When the GitHub installation picker fails to load accounts (e.g. expired OAuth token), the modal now shows a helpful error state with a "Reconnect GitHub" button that triggers re-authentication instead of just a plain red error message. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
🧪 BenchmarkShould we run the Virtual MCP strategy benchmark for this PR? React with 👍 to run the benchmark.
Benchmark will run on the next push after you react. |
Contributor
Release OptionsSuggested: Patch ( React with an emoji to override the release type:
Current version:
|
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/mesh/src/web/components/github-repo-picker.tsx">
<violation number="1" location="apps/mesh/src/web/components/github-repo-picker.tsx:598">
P2: Reconnect swallows token-save failures, which can leave the connection unauthenticated without clear user feedback.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| }), | ||
| }, | ||
| ); | ||
| if (!response.ok) { |
Contributor
There was a problem hiding this comment.
P2: Reconnect swallows token-save failures, which can leave the connection unauthenticated without clear user feedback.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/mesh/src/web/components/github-repo-picker.tsx, line 598:
<comment>Reconnect swallows token-save failures, which can leave the connection unauthenticated without clear user feedback.</comment>
<file context>
@@ -562,6 +564,55 @@ function InstallationPicker({
+ }),
+ },
+ );
+ if (!response.ok) {
+ console.error("Failed to save OAuth token:", await response.text());
+ }
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AutoInstallGitHubUIerror design for visual consistencyTest plan
🤖 Generated with Claude Code
Summary by cubic
Shows an actionable error state in the GitHub import modal when accounts fail to load, with a “Reconnect GitHub” flow and a “Retry” option to recover without manual steps. Improves UX for expired/invalid OAuth tokens and matches the existing error design.
authenticateMcp, persists tokens via the connection OAuth endpoint, then refetches installations.Written for commit 7b52b87. Summary will update on new commits. Review in cubic