feat(home): landing-page agent + plain clone URL support#3361
Open
rafavalls wants to merge 2 commits into
Open
feat(home): landing-page agent + plain clone URL support#3361rafavalls wants to merge 2 commits into
rafavalls wants to merge 2 commits into
Conversation
Adds a "Build landing page" tile that creates a vMCP pre-wired to the Next.js + shadcn template, with eager VM_START so the preview is ready when the user arrives. Generalises repo-backed vMCPs to also accept a plain cloneUrl (no GitHub OAuth needed), with unauthenticated runtime detection on github.com URLs. Also includes stability fixes for the sandbox host runner (PTY-to-pipe spawn fallback with env merge, retry on posix_spawn errors during clone, child_process.spawn for setup steps), dynamic ingress port autoselection, and a credentials-file refresher for the s3-sync daemon so subshells share STS creds. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
🧪 BenchmarkShould we run the Virtual MCP strategy benchmark for this PR? React with 👍 to run the benchmark.
Benchmark will run on the next push after you react. |
Contributor
Release OptionsSuggested: Minor ( React with an emoji to override the release type:
Current version:
|
rafavalls
added a commit
that referenced
this pull request
May 20, 2026
…awnp The clone failure surfaced as "[orchestrator] clone failed: posix_spawnp failed." on macOS — node-pty's forkpty can fail deterministically on bun + libuv before the wrapped command (git ls-remote, git clone, etc.) ever runs. Setup commands don't need a TTY, so swap them to `node:child_process.spawn` instead. We use Node's spawn (not Bun.spawn) because we need `uid`/`gid` for the privilege drop path; Bun.spawn doesn't expose those. stdout and stderr both pipe into the existing onChunk stream so callers see the same log shape. Also adds `posix_spawnp failed` / `Resource temporarily unavailable` to the clone's TRANSIENT_ERRORS list and wraps `runStep` in a try/catch so spawn-level throws are treated as transient and retried, instead of hard-failing the orchestrator's clone step. Ports the relevant subset of #3361's stability fixes — minimum needed to make the Web app tile usable on macOS dev machines. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
rafavalls
added a commit
that referenced
this pull request
May 20, 2026
Proposal for adding bundle-based persistence so vibecoded sandboxes (cloneUrl-backed vMCPs from #3361) survive idle/restart without GitHub. Covers a small VibecodeStore abstraction (local FS + S3 IRSA), daemon snapshot routes that produce/consume a `git bundle`, a mesh-side idle poller, and a restore pre-step in VM_START. The restore path feeds the bundle file path as cloneUrl so the existing setup orchestrator handles clone/install/start unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
rafavalls
added a commit
that referenced
this pull request
May 20, 2026
…awnp The clone failure surfaced as "[orchestrator] clone failed: posix_spawnp failed." on macOS — node-pty's forkpty can fail deterministically on bun + libuv before the wrapped command (git ls-remote, git clone, etc.) ever runs. Setup commands don't need a TTY, so swap them to `node:child_process.spawn` instead. We use Node's spawn (not Bun.spawn) because we need `uid`/`gid` for the privilege drop path; Bun.spawn doesn't expose those. stdout and stderr both pipe into the existing onChunk stream so callers see the same log shape. Also adds `posix_spawnp failed` / `Resource temporarily unavailable` to the clone's TRANSIENT_ERRORS list and wraps `runStep` in a try/catch so spawn-level throws are treated as transient and retried, instead of hard-failing the orchestrator's clone step. Ports the relevant subset of #3361's stability fixes — minimum needed to make the Web app tile usable on macOS dev machines. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this contribution about?
Adds a "Build landing page" tile on the home page that creates a vMCP pre-wired to the Next.js + shadcn template and eagerly fires
VM_STARTso the preview is ready by the time the user arrives. Generalises repo-backed vMCPs to also accept a plaincloneUrl(no GitHub OAuth required) with unauthenticated runtime detection for public github.com URLs, and threads the new source through preview-tab gating, branch resolution, and stream-core VM keying. Also includes sandbox host-runner stability fixes — PTY-to-pipe spawn fallback with env merge, retry onposix_spawnerrors during clone,child_process.spawnfor setup steps — plus dynamic ingress port autoselection and a credentials-file refresher for the s3-sync daemon so subshells share STS creds.How to Test
cloneUrlset (and nogithubRepo), confirm the preview tab and per-branch VM keying still work, and that the displayed clone URL has any embeddeduser:token@credentials stripped.EADDRINUSE.Review Checklist
Summary by cubic
Adds a “Build landing page” tile that spins up a Next.js + shadcn template with an eager
VM_START, and adds plaincloneUrlsupport so repo-backed agents work without GitHub OAuth. Also hardens the sandbox runner and auto-picks a free local ingress port to keep preview reliable.New Features
cloneUrl: supports public GitHub URLs without auth, detects package manager and dev port via unauthenticated API, strips anyuser:token@from display, and updates branch resolution + VM keying to treatcloneUrllikegithubRepo.cloneUrl).Stability
child_process.spawn, and retries clone onposix_spawnfailures.SANDBOX_INGRESS_PORTto avoidEADDRINUSEwhen multiple workspaces run.Written for commit b839c24. Summary will update on new commits.