add WalkPlayerTo RPC and walk fields to movement components#374
Merged
robtfm merged 1 commit intoprotocol-squadfrom Mar 10, 2026
Merged
add WalkPlayerTo RPC and walk fields to movement components#374robtfm merged 1 commit intoprotocol-squadfrom
robtfm merged 1 commit intoprotocol-squadfrom
Conversation
- Add WalkPlayerTo RPC to RestrictedActionsService with position, stop_threshold and optional timeout - Add walk_target and walk_threshold fields to PBAvatarMovementInfo (engine -> scene) - Add walk_success optional bool to PBAvatarMovement (scene -> engine, set for one frame on completion) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Test this pull request
|
This was referenced Mar 10, 2026
kuruk-mm
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WalkPlayerToRPC toRestrictedActionsServicewithposition,stop_threshold, and optionaltimeoutwalk_target(Vector3) andwalk_threshold(float) fields toPBAvatarMovementInfo(engine → scene broadcast each frame while walk is active)walk_success(optional bool) toPBAvatarMovement(scene → engine, set for one frame on completion/failure)The walk flow: scene calls
walkPlayerTo→ engine setswalk_target/walk_thresholdinAvatarMovementInfoeach frame → movement scene steers the avatar toward the target → on arrival (or timeout/cancellation) the scene writeswalk_successback → engine resolves the RPC call.🤖 Generated with Claude Code