Repository navigation
fix(calls): retire first clause window after short replies - #2629
rudycelekli wants to merge 2 commits into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
|
All contributors on this pull request have signed the VoiceStudio CLA. Thank you! |
|
[Medium risk] Adjusts when speech output waits for sentence boundaries in calls. The PR appears safe to merge; no merge-changing defect was identified. SummaryThe PR retires aggressive first-clause flushing after a short sentence is emitted.
Reviews (1) · Last reviewed commit: "docs: link short-flush regression report..." |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe sentence chunker now clears its first-flush state after emitting a short sentence. Tests, the call integration documentation, and the changelog cover the updated boundary behavior. ChangesShort reply flush behavior
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Suggested reviewers: Fixed issue severity: <fixed_issue_severity>Low</fixed_issue_severity> Merge Risk: ⚪ Minimal · up to The change prevents later clauses from using the first-clause shortcut after a short reply. No actionable merge-blocking risk is established. 🚥 Pre-merge checks | ✅ 8 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (8 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
recheck |
|
Thanks for the report and the work on this, @rudycelekli. The problem in #2628 is fixed on |
Summary
A short first reply such as
Hello!empties the buffer but leaves the first-clause window active. In the aggressive call-agent mode, a later clause is then emitted early as though it were still the first clause.Changes
Type
Testing
Hosted CI audit at 2026-10-06T12:35:20.584679+00:00: no failing latest checks; required CLA passes. All latest reported checks completed successfully. No upstream merge performed.
Existing sentence-chunker tests cover the short reply, buffering of the next clause, a new-turn reset and the non-emitting minimum-word control.
Regression against unchanged main production source: 1 failed, 65 passed. After the fix: 66 passed; 79 with changelog gate.
Python 3.13 with
HF_HUB_OFFLINE=1and an empty Hugging Face cache. No model download or inference calls.Diff check and Python compilation pass.
Full backend/Electron suites were not run locally; focused tests alone do not establish hosted security or platform gates. Hosted results are reported separately below.
Checklist
smoke-matrixCI — not run locallyCloses #2628
Short replies now retire the first-clause window, so later clauses wait for normal sentence boundaries; regression tests cover the next clause, turn reset, and minimum-word guard. This prevents later speech from being emitted early in aggressive call-agent mode. Full backend, Electron, hosted security, and platform-matrix gates were not run.