Jupyterlab>4.1#69
Open
brichet wants to merge 5 commits into
Open
Conversation
Contributor
|
Hello! Thanks a lot @brichet for this MR! Any chances to have it reviewed and merged sometime soon? The semester is about to start and this is blocking us from upgrading Jupyterlab to > 4.0. Thank you in advance, |
Contributor
|
For information: to move on, nbrichet is maintaining a fork of jupyterlab-deck under the name jupyterlab-slideshow; it's published on pypi and working well for me. Of course, pending interest by @deathbeds, this could be merged back into jupyterlab-deck. |
|
Thanks, the fork works great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update compatibility to
jupyterlab>=4.1, and update dependencies accordingly, the keyboard shortcuts are not compatible starting from version 4.1.0.Checklist
doit lintlocallyReferences
Related to #63
Code changes
When the notebook changes to full windowed mode (the default since lab 4.1) some CSS rules are applied to the viewport node, and are not properly removed when switching back to 'no windowing' mode. These rules should be fixed upstream in Jupyterlab, but are also fixed here for backward compatibility.
.jp-WindowedPanel-innerhas been fixed in lab 2.2 with Fix width and margins of the notebook footer. jupyterlab/jupyterlab#16383.jp-WindowedPanel-viewportshould be fixed with Restore viewportmin-heightwhen not windowing jupyterlab/jupyterlab#16979 (comment).jp-ThemedContainerUser-facing changes
None
Backwards-incompatible changes
None