Fix navigation if previous is subslide#62
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
- Coverage 93.66% 93.45% -0.22%
==========================================
Files 16 16
Lines 1327 1330 +3
Branches 274 275 +1
==========================================
Hits 1243 1243
- Misses 42 44 +2
- Partials 42 43 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Yep, we'll want a fixture that concretely demonstrates this pattern. This could either be through adding a new fixture notebook in |
|
@bollwyvl I added a test on this specific pattern. |
|
Thanks for the work here! I'll try it soon :-) |
|
Hi! |
Fixes a a navigation problem with sub-slide.
A sub-slide (1) without fragment and (2) followed by another sub-slide is ignored in the navigation.
This PR solve it by checking if a sub-slide is preceded by another sub-slide.
Checklist
doit lintlocallyReferences
Expressed in #49
Code changes
When creating the extent (navigation) for a sub-slide, check if there is a previous sub-slide.
User-facing changes
None except for the navigation.
Backwards-incompatible changes
None