Skip to content

Fix navigation if previous is subslide#62

Open
brichet wants to merge 2 commits into
deathbeds:mainfrom
brichet:fix_subslide_navigation
Open

Fix navigation if previous is subslide#62
brichet wants to merge 2 commits into
deathbeds:mainfrom
brichet:fix_subslide_navigation

Conversation

@brichet
Copy link
Copy Markdown

@brichet brichet commented Jan 12, 2024

Fixes a a navigation problem with sub-slide.

A sub-slide (1) without fragment and (2) followed by another sub-slide is ignored in the navigation.
This PR solve it by checking if a sub-slide is preceded by another sub-slide.

Checklist

  • ran doit lint locally

References

Expressed in #49

Expected: the following subslide "Subslide1" is displayed
Got: the subslide "subslide2" is displayed

Code changes

When creating the extent (navigation) for a sub-slide, check if there is a previous sub-slide.

User-facing changes

None except for the navigation.

Backwards-incompatible changes

None

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 13, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d24d22c) 93.66% compared to head (059b6f1) 93.45%.

❗ Current head 059b6f1 differs from pull request most recent head 38b3623. Consider uploading reports for the commit 38b3623 to get more accurate results

Files Patch % Lines
js/jupyterlab-deck/src/notebook/presenter.ts 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   93.66%   93.45%   -0.22%     
==========================================
  Files          16       16              
  Lines        1327     1330       +3     
  Branches      274      275       +1     
==========================================
  Hits         1243     1243              
- Misses         42       44       +2     
- Partials       42       43       +1     
Flag Coverage Δ
front-end 93.40% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bollwyvl
Copy link
Copy Markdown
Contributor

Yep, we'll want a fixture that concretely demonstrates this pattern.

This could either be through adding a new fixture notebook in examples, or updating an existing one to have this specific pattern so it can be observed, and therefore covered, and stay fixed.

@brichet
Copy link
Copy Markdown
Author

brichet commented Jan 18, 2024

@bollwyvl I added a test on this specific pattern.

@nthiery
Copy link
Copy Markdown
Contributor

nthiery commented Feb 2, 2024

Thanks for the work here! I'll try it soon :-)

@nthiery
Copy link
Copy Markdown
Contributor

nthiery commented Apr 8, 2025

Hi!
I had forgotten to report here: I confirm that navigation to previous sublide works smoothly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants