Skip to content

a11y prs#16

Draft
bollwyvl wants to merge 17 commits into
deathbeds:mainfrom
bollwyvl:a11y-prs
Draft

a11y prs#16
bollwyvl wants to merge 17 commits into
deathbeds:mainfrom
bollwyvl:a11y-prs

Conversation

@bollwyvl
Copy link
Copy Markdown
Contributor

@bollwyvl bollwyvl commented Dec 3, 2023

what kind of request is this?

  • a preview site on ReadTheDocs
    • it only adds a jupyak_config.toml
  • a jupyak code change
    • it adds new features, described below

for preview sites

how should a visitor use the preview site?

  1. open a new private browser window
  2. go to https://jupyak--16.org.readthedocs.build/en/16/_static/work/lite/lab/
  3. see the Launcher
  4. use tab one or more times to focus the Python (pyodide) launcher item
  5. press enter to start a new notebook from the launcher
  6. press esc to enter Command Mode
  7. use shift+tab a few times navigate back to Close button for the activity
  8. use delete to close the notebook
  9. accept the dialog default with enter

where is the main discussion?

t03857785/jupyterlab#12

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2023

jupyak-badge 👈 Try it on ReadTheDocs

@bollwyvl
Copy link
Copy Markdown
Contributor Author

bollwyvl commented Dec 3, 2023

The --ours didn't seem to help, trying -sort -Xtheirs again....

bollwyvl added a commit to bollwyvl/jupyak that referenced this pull request Dec 4, 2023
Copy link
Copy Markdown
Member

@tonyfast tonyfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adds aria live pull requests to the build

Comment thread jupyak_config.toml
Comment thread jupyak_config.toml Outdated
Comment thread jupyak_config.toml Outdated
Comment thread jupyak_config.toml Outdated
@bollwyvl bollwyvl closed this Dec 13, 2023
@bollwyvl bollwyvl reopened this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants