Skip to content

fix(runtime): run php-fpm as remapped user #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddtcorex merged 1 commit into from
May 28, 2026
Merged

fix(runtime): run php-fpm as remapped user #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docker/php/etc/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,15 @@ if [ -n "${PUID:-}" ] && [ "${PUID}" != "1000" ]; then
fi
fi

UID_REMAP_CHANGED=0
if [ -n "${PUID:-}" ]; then
CURRENT_UID=$(id -u www-data)
if [ "${CURRENT_UID}" != "${PUID}" ]; then
echo "Updating www-data UID to ${PUID}..."
if ! sudo usermod -u "${PUID}" www-data; then
echo "Warning: could not update www-data UID to ${PUID}; continuing with UID ${CURRENT_UID}." >&2
else
UID_REMAP_CHANGED=1
fi
fi
fi
Expand Down Expand Up @@ -136,4 +139,8 @@ if [ -n "${NODE_VERSION:-}" ]; then
fi
fi

if [ "${UID_REMAP_CHANGED}" = "1" ] && [ "$(id -u)" != "$(id -u www-data)" ]; then
exec sudo -E -H -u www-data "$@"
fi

exec "$@"
10 changes: 10 additions & 0 deletions tests/php_runtime_cron_support_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,16 @@ func TestPHPEntrypointUpdatesGIDBeforeUID(t *testing.T) {
}
}

func TestPHPEntrypointRelaunchesProcessAfterUIDRemap(t *testing.T) {
content := readProjectFileForTest(t, filepath.Join("docker", "php", "etc", "entrypoint.sh"))
if !strings.Contains(content, "UID_REMAP_CHANGED=1") {
t.Fatalf("expected php entrypoint to track successful UID remaps, got:\n%s", content)
}
if !strings.Contains(content, "exec sudo -E -H -u www-data \"$@\"") {
t.Fatalf("expected php entrypoint to launch php-fpm as remapped www-data, got:\n%s", content)
}
}

func TestPHPEntrypointStartsCrondBestEffort(t *testing.T) {
content := readProjectFileForTest(t, filepath.Join("docker", "php", "etc", "entrypoint.sh"))
if !strings.Contains(content, "sudo crond 2>/dev/null || true") {
Expand Down