Potential fix for code scanning alert no. 2: Disabling certificate validation - #1
Closed
ddrayko wants to merge 1 commit into
Closed
Potential fix for code scanning alert no. 2: Disabling certificate validation#1ddrayko wants to merge 1 commit into
ddrayko wants to merge 1 commit into
Conversation
…lidation Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Owner
Author
|
May cause the ping for certain self-signed services to fail |
Repository owner
locked and limited conversation to collaborators
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ddrayko/homy/security/code-scanning/2
The correct fix is to stop disabling TLS certificate validation. For HTTPS requests, either omit
rejectUnauthorizedentirely (defaults to secure behavior) or set it totrue. To preserve existing functionality while removing the vulnerability, the best minimal change is to set it explicitly totruein the existing options object used bymod.get.In
server.js, update thepingUrlfunction at the options definition (line 80 in the provided snippet):rejectUnauthorized: falsetorejectUnauthorized: true.This preserves timeout behavior and request flow while enforcing standard TLS authentication.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.