[codex] Tighten savepoint skill docs#26
Conversation
There was a problem hiding this comment.
Code Review
This pull request simplifies and streamlines the documentation in README.md, README.ko.md, and SKILL.md by removing detailed maintainer/migration commands, CLI shortcut details, and multi-line code blocks. It also updates scripts/validate-repo.py to enforce these new constraints, including a strict line count limit of 55–65 lines for SKILL.md. A review comment correctly points out that SKILL.md currently has 66 lines, which would fail this new validation check, and suggests removing an empty line to meet the requirement.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| # Savepoint |
There was a problem hiding this comment.
The current line count of SKILL.md is 66 lines, which will fail the repository validation check in scripts/validate-repo.py (which strictly enforces a limit of 55-65 lines). Removing the unnecessary empty line right after the frontmatter delimiter reduces the total line count to exactly 65 lines, satisfying the validation contract.
| # Savepoint | |
| # Savepoint |
Summary
skills/savepoint/SKILL.mdto a compact contract while preserving save/load/text modes and recovery guardrails.Why
The feedback is valid for this repository: Savepoint should not be reduced to a tiny handoff summary, but the skill should also avoid carrying README-level or maintainer-level detail. The actual repo reference names are
references/contract.md,references/safety.md, andreferences/template.md, so the skill keeps those names instead of the longer names in the pasted draft.Validation
python3 scripts/check-frontmatter.pypython3 scripts/check-marker-block.pypython3 scripts/check-marker-semantics.pypython3 scripts/validate-examples.pypython3 scripts/check-output-contract.pypython3 scripts/validate-repo.pypython3 scripts/check-savepoint-renderer.py(Windows symlink privilege case skipped; remaining tests ok)python3 scripts/check-install-helper.py(Windows symlink privilege case skipped; remaining tests ok)python3 scripts/savepoint.py validate --allow-example-paths examples/SAVEPOINT.filled.example.md examples/file-bugfix/SAVEPOINT.md examples/file-architecture/SAVEPOINT.md examples/unsafe-savepoint/SAVEPOINT.mdgit diff --checkgit diff --cached --checkpython3 -m compileall -q skills/savepoint/scripts scripts