Skip to content

Refine audit output and intentional reference handling#65

Merged
dd3ok merged 4 commits into
mainfrom
dogfood-intentional-references
May 27, 2026
Merged

Refine audit output and intentional reference handling#65
dd3ok merged 4 commits into
mainfrom
dogfood-intentional-references

Conversation

@dd3ok

@dd3ok dd3ok commented May 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • treat template-style and environment-rooted reference paths as intentional non-local references instead of missing repo files
  • make --out write artifacts without echoing duplicate content, while preserving GitHub Actions annotations on stdout
  • add eval coverage and docs for the refined behavior

Verification

  • python3 -m py_compile lucid.py skills/lucid/scripts/lucid.py scripts/validate-skill.py scripts/validate-evals.py scripts/validate-no-dangerous-io.py scripts/validate-docs.py scripts/validate-package-skill.py scripts/package-skill.py
  • python3 scripts/validate-docs.py
  • python3 scripts/validate-skill.py
  • python3 scripts/validate-evals.py
  • python3 scripts/validate-no-dangerous-io.py
  • python3 scripts/validate-package-skill.py
  • python3 skills/lucid/scripts/lucid.py verify --root . --strict
  • git diff --check

Notes

  • keeps existing lucid.ignore.json suppression model; no new broad config or rule engine
  • deliberately does not quiet audit --format github-actions stdout because annotations are the output contract

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces changes to suppress duplicate stdout output when the --out option is provided for several commands, while ensuring GitHub Actions annotations are still printed. It also updates the reference-checking logic to treat template-style and environment-rooted paths as intentional non-local references rather than missing files. The reviewer feedback suggests improving the robustness of is_external_reference_path using a regex that supports all bracketed environment variables, and simplifying is_template_path_part by removing a redundant regex check and enforcing correctly paired brackets.

Comment thread skills/lucid/scripts/lucid.py Outdated
Comment thread skills/lucid/scripts/lucid.py Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11b47f8a0e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills/lucid/scripts/lucid.py Outdated
@dd3ok dd3ok changed the title Refine dogfood audit ergonomics Refine audit output and intentional reference handling May 27, 2026
@dd3ok dd3ok merged commit 83d553c into main May 27, 2026
1 check passed
@dd3ok dd3ok deleted the dogfood-intentional-references branch May 27, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant