Skip to content

fix: use math.fsum in variance to avoid fp rounding when all credits are equal #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcondrey merged 1 commit into from
Jul 27, 2026
Merged

fix: use math.fsum in variance to avoid fp rounding when all credits are equal #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions misterdev/core/evolution/partial_credit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
regressions==0 + resolved_rate (see fitness.py). Pure and deterministic.
"""

import math
from dataclasses import dataclass
from typing import Iterable, Optional, Sequence, Tuple

Expand Down Expand Up @@ -99,8 +100,8 @@ def variance(self) -> float:
"""Sample variance of the per-task credits (population form)."""
if self.total < 1:
return 0.0
m = self.mean_credit
return sum((c - m) ** 2 for c in self.credits) / self.total
m = math.fsum(self.credits) / self.total
return math.fsum((c - m) ** 2 for c in self.credits) / self.total

@property
def stderr(self) -> float:
Expand Down
Loading